Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update task-item.ts nodeview to update data-checked #1567

Merged
merged 2 commits into from
Jul 10, 2021

Conversation

BrianHung
Copy link
Contributor

@BrianHung BrianHung commented Jul 9, 2021

#1566

Another alternative would be to remove the label wrapper element so the nodeview output is

<li data-checked="true" class="">
  <input type="checkbox">
  <div><p>A list item</p></div>
</li>

This would allow people to style the content of the todo-item with a sibling css selector:

ul[data-type=taskList] > li > input[type=checkbox] + div { 
  text-decoration: line-through;
}

@hanspagel hanspagel self-assigned this Jul 10, 2021
@hanspagel hanspagel merged commit 1ac8353 into ueberdosis:main Jul 10, 2021
@hanspagel
Copy link
Contributor

Thanks for the fix @BrianHung! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants