Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search and Replace #2075

Conversation

sereneinserenade
Copy link
Contributor

@sereneinserenade sereneinserenade commented Oct 23, 2021

Preview:

Bildschirmaufnahme.2021-10-23.um.01.58.29.mov

Notes for reviewers:

A running version can be played around at https://tiptap-search-n-replace-demo.vercel.app/ (repo: https://github.com/sereneinserenade/tiptap-search-n-replace-demo ).

Also if this PR is ok, would you also mention it on #819 ?

PS(a small request):
If after reviewing you find everything ok, would you mind adding hacktoberfest eligible lable to this PR? I only need one more PR for the tee 😁

@sereneinserenade sereneinserenade mentioned this pull request Oct 26, 2021
10 tasks
@hanspagel hanspagel mentioned this pull request Oct 26, 2021
6 tasks
@hanspagel
Copy link
Contributor

Thanks for your work on this, you’ve done a great job! 🙌

From looking through it I think there are a few things (code style, approach and some behaviours) that we’d just do slightly different before we’ll release it, support it and maintain it as an official extension. We’ve been way more open with community contributions for official extensions in v1, but that always led to extra work (issues, PRs to fix the issues, new issues, new PRs …) that we couldn’t handle well for things we’ve never really worked through. The search and replace example was one of those contributions in v1.

Anyway, I’m sure your port for v2 already helps a ton of people. We just don't want to take responsibility for it now so I’m closing this here, but added it to the pinned (and very popular) #819 issue to make it available to everyone who’d like to use it now. ✌️

@hanspagel hanspagel closed this Oct 26, 2021
@sereneinserenade
Copy link
Contributor Author

That seems fair, thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants