Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating menu - remove composition check #2137

Merged
merged 1 commit into from Nov 10, 2021

Conversation

dkrym
Copy link
Contributor

@dkrym dkrym commented Nov 5, 2021

I did some more debugging on #1994 and found out that the problem (floating menu does not hide when you type) happens when composition is true (https://firefox-source-docs.mozilla.org/editor/IMEHandlingGuide.html).

The common cases I found:

This PR simply removes check if composition is true. I use floating menu for both menu on empty line (as Tiptap example does) and menu attached at the end of the current line as you type. In both cases, I want update position/hide menu on typing any character, even if it is in composition mode.

I think we don't care for composition and shouldShow() should handle it.

The question I have is Was check for composition added for any specific reason?

I don't have experience with composition so maybe I am missing something and the check is actually needed, in that case reject this PR please.

Fixes #1994

remove composing from floating menu
@philippkuehn philippkuehn merged commit d0d0696 into ueberdosis:main Nov 10, 2021
@philippkuehn
Copy link
Contributor

Thanks! Great finding. I don’t think we need the composition check here 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Floating menu mobile chrome
2 participants