Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve backspace handling #2284

Merged
merged 4 commits into from
Dec 16, 2021
Merged

Conversation

philippkuehn
Copy link
Contributor

@philippkuehn philippkuehn commented Dec 16, 2021

With this PR we try to improve backspace handling in two cases

  1. Convert an empty node to the default node when pressing backspace at the start of the document.
  2. After pressing cmd+a and backspace the node is converted to the default node

fixes #2281

preview: https://deploy-preview-2284--tiptap-embed.netlify.app/preview/Examples/Default

@netlify
Copy link

netlify bot commented Dec 16, 2021

✔️ Deploy Preview for tiptap-embed ready!

🔨 Explore the source changes: d0094ef

🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61bafe5843740b0007f58124

😎 Browse the preview: https://deploy-preview-2284--tiptap-embed.netlify.app

@philippkuehn philippkuehn merged commit 8ed485b into main Dec 16, 2021
@philippkuehn philippkuehn deleted the feature/improve-backspace-handling branch December 16, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't clear formatting of first line if it's a block node
1 participant