Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setup script syntax to Vue 3 install docs #2324

Merged
merged 1 commit into from Jan 3, 2022
Merged

Added setup script syntax to Vue 3 install docs #2324

merged 1 commit into from Jan 3, 2022

Conversation

NuroDev
Copy link
Contributor

@NuroDev NuroDev commented Dec 29, 2021

What

Another newly added feature to Vue 3 has been the addition of the setup script syntax. Feels like it might be good to add this as another possible installation method.

@netlify
Copy link

netlify bot commented Dec 29, 2021

✔️ Deploy Preview for tiptap-embed ready!

🔨 Explore the source changes: 015dd1a

🔍 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61cbd47bad1f9b0007e1cbce

😎 Browse the preview: https://deploy-preview-2324--tiptap-embed.netlify.app

@@ -106,6 +106,26 @@ export default {
</script>
```

Or feel free to use the new [`<script setup>` syntax](https://v3.vuejs.org/api/sfc-script-setup.html).

```html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub does support vue as a possible code block language but unsure/haven't tested if the documentation generator here will support it.

Using html like other code blocks in the mean time

@NuroDev NuroDev marked this pull request as ready for review December 29, 2021 03:24
@philippkuehn
Copy link
Contributor

Looks good. Thanks!

@philippkuehn philippkuehn merged commit 989c027 into ueberdosis:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants