Allow individual Typography rules to be disabled #2449
Conversation
|
鉁旓笍 Deploy Preview for tiptap-embed ready! 馃敤 Explore the source changes: 574ed26 馃攳 Inspect the deploy log: https://app.netlify.com/sites/tiptap-embed/deploys/61f3011698ef2c0008f5789f 馃槑 Browse the preview: https://deploy-preview-2449--tiptap-embed.netlify.app |
| export interface TypographyOptions { | ||
| emDash: false, | ||
| ellipsis: false, | ||
| openDoubleQuote: false, | ||
| closeDoubleQuote: false, | ||
| openSingleQuote: false, | ||
| closeSingleQuote: false, | ||
| leftArrow: false, | ||
| rightArrow: false, | ||
| copyright: false, | ||
| trademark: false, | ||
| registeredTrademark: false, | ||
| oneHalf: false, | ||
| plusMinus: false, | ||
| notEqual: false, | ||
| laquo: false, | ||
| raquo: false, | ||
| multiplication: false, | ||
| superscriptTwo: false, | ||
| superscriptThree: false, | ||
| oneQuarter: false, | ||
| threeQuarters: false, | ||
| } | ||
|
|
There was a problem hiding this comment.
These should be boolean, right?
There was a problem hiding this comment.
I followed the same approach used in StarterKit, where all rules are included by default and you can only disable the ones you don't want.
I can change this to boolean if you think that makes more sense. Let me know, and I'll make the change.
| name: 'typography', | ||
|
|
||
| addInputRules() { |
There was a problem hiding this comment.
You should also define addOptions() with its default values here.
There was a problem hiding this comment.
If we keep the current approach where the options can only be set to false, I believe we don't need addOptions. Again, followed the exact same approach as StarterKit to keep things simple. But I can change to boolean and add addOptions with default set to true.
|
Thanks! |
The Typography extension is a great extension, but it's not very customizable. It's all or nothing for the included input rules, and this doesn't really work for us. We want some rules enabled, but all of them. I thought it would be nice if the extension could be fully configurable, allowing one to disable specific rules if one desires.
Hopefully this is something you agree with including in the official extension, otherwise we'll have to maintain our own version of this. Which is not a big deal, but it would be awesome if this could be integrated 馃榾