Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve Vue nodeViewProps typing #2681

Merged
merged 1 commit into from Apr 12, 2022

Conversation

DanSnow
Copy link
Contributor

@DanSnow DanSnow commented Apr 5, 2022

Description

This PR add as const to every required options in nodeViewProps.

Resolved #2654

Testing

  1. run yarn rollup -c --scope @tiptap/vue-2 and yarn rollup -c --scope @tiptap/vue-3
  2. Then verify the typing is
export declare const nodeViewProps: {
    editor: {
        type: PropType<import("@tiptap/core").Editor>;
        required: true;
    };
   // ...
}

instead of:

export declare const nodeViewProps: {
    editor: {
        type: PropType<import("@tiptap/core").Editor>;
        required: boolean;
    };
   // ...
}

@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 190a699
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/624bdda8b6a9d6000c5c8375
😎 Deploy Preview https://deploy-preview-2681--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch merged commit 08539b9 into ueberdosis:main Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve nodeViewProps typing for Vue
2 participants