fix: don't override behaviour of Home / End in pc keymap #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
2 tasks
scottsidwell
force-pushed
the
fix/pc-keymap-for-home-and-end
branch
from
a13618c
to
3cbe6e6
Compare
Similarly removed in Prosemirror at ProseMirror/prosemirror-commands@20371c58 For users who wish to preserve this behaviour, they can achieve this via: ```javascript const CustomKeyboardBehaviour = Extension.create({ addKeyboardShortcuts() { return { ['Home']: () => this.editor.commands.selectTextblockStart(), ['End']: () => this.editor.commands.selectTextblockEnd(), } } }) const editor = new Editor({ extensions: [ // Register your custom extension with the editor. CustomKeyboardBehaviour, ] }); ```
scottsidwell
force-pushed
the
fix/pc-keymap-for-home-and-end
branch
from
3cbe6e6
to
d270419
Compare
|
Looks good to me, thank your for your contribution. I agree - the default editor should always be mimicking the default OS behaviour. |
2 tasks
|
@bdbch Are you able to build and publish new releases? Would love to get a version with this in... |
|
We're looking for releasing a new version very soon! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2685 by removing the Home/End keybindings in the PC keymap.
This was similarly removed in Prosemirror at ProseMirror/prosemirror-commands@20371c58, to favour default browser / OS behaviour.
Note: This behaviour continues to be preserved on Mac under the
Ctrl-aandCtrl-ekeysFor users who wish to preserve this behaviour, they can achieve this via a custom extension:
If we haven't reached consensus on this change, then feel free to ignore. Just raising the PR in case this is all that's missing to resolve the issue.