Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests for examples #2777

Merged
merged 19 commits into from May 16, 2022
Merged

Cypress tests for examples #2777

merged 19 commits into from May 16, 2022

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented May 10, 2022

This PR implements missing cypress tests for all examples. I'll keep this marked as a draft until I'm done with the implementation. Feel free to hop in and give me feedback on the already created tests.

See #2087

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit b354f79
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/6282209a8c97770009de4aa8
😎 Deploy Preview https://deploy-preview-2777--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch force-pushed the maintainment/example-tests branch from 59bce07 to 2c9d676 Compare May 10, 2022 17:47
@bdbch bdbch force-pushed the maintainment/example-tests branch from 2c9d676 to 2a23f4f Compare May 10, 2022 17:48
@bdbch bdbch marked this pull request as ready for review May 13, 2022 14:47
@bdbch bdbch requested a review from svenadlung May 13, 2022 14:47
@bdbch bdbch self-assigned this May 13, 2022
@bdbch bdbch changed the title DRAFT: Cypress tests for examples Cypress tests for examples May 13, 2022
Copy link
Contributor

@svenadlung svenadlung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the question about the CSSModules demo and the comment about console.log it looks fine to me.

demos/src/Examples/CSSModules/Vue/index.vue Outdated Show resolved Hide resolved
@bdbch bdbch merged commit fda0c74 into main May 16, 2022
@bdbch bdbch deleted the maintainment/example-tests branch May 16, 2022 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants