Fix InputRule regex matcher ignoring non-text leaflets in textBefore #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
I forced push a different solution proposed by @rfgamaral in #2806 (thanks!). We now include the textContent of non-text leafs & fallback to a |
rfgamaral
reviewed
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix #2806
Currently non-text leaflets (which for example the Mention example is) this matcher is inserting space (
I added a placeholder for this check resulting in non-text leafs being replaced with
%leaf%which will stop those regex from returning true when a non-text leaf is used in front.Since this function is not used for anything else but this check I think it's okay to use this %leaf% placeholder but I'm open for feedback or ideas how to solve this differently.