Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension/youtube): ✨ new youtube embed extension #2814

Merged
merged 10 commits into from Jun 17, 2022

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented May 20, 2022

New youtube video extension

This PR adds a new video extension for YouTube embeds. It supports YouTube and YouTube music links and automatically handles YouTube URL to YouTube embed URL conversion.

Options:

Option Description
inline Controls if the embed is inline or a block
width The embed width
height The embed height
controls Enables or disables video controls
nocookie Enables or disables nocookie mode
allowFullscreen Enables or disables fullscreen functionality on iframe

Commands:

Command Description
setYoutubeVideo(options) Inserts a youtube iframe node at current position

Checks

  • Implement Functionality
    • Support YouTube URLs
    • Support YouTube Music URLs
    • Handle copy and paste with embed URLs
  • Implement tests
  • Add documentation

Videos

Adding videos with different sizes

2022_05_21-00_37_10-msedge.mp4

Adding videos from YouTube Music

2022_05_21-00_38_01-msedge.mp4

Pasting multiple videos with correct videos

2022_05_21-00_39_53-msedge.mp4

@bdbch bdbch requested a review from svenadlung May 20, 2022 22:36
@bdbch bdbch self-assigned this May 20, 2022
@netlify
Copy link

netlify bot commented May 20, 2022

Deploy Preview for tiptap-embed failed.

Name Link
🔨 Latest commit 76c3d65
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/62abf3cd352f460008f43381

@bdbch bdbch merged commit 1c0554b into main Jun 17, 2022
@bdbch bdbch deleted the bdbch/video-extension branch June 17, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants