Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom protocols in extension-link #2832

Merged
merged 1 commit into from Jun 6, 2022

Conversation

shaunabanana
Copy link
Contributor

This pull request adds custom protocols to extension-link. Previously, only urls beginning with http & https are recognized. Now it is possible to do the following:

Link.configure({
    protocols: ['ftp']
})

And ftp:// links will be automatically recognized and turned into hyperlinks.

The registration of custom protocols uses the builtin function registerCustomProtocol of linkifyjs, which is already used by the extension.

Docs are updated as well.

@netlify
Copy link

netlify bot commented May 29, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 904371d
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/62936f1a092c85000845bde0
😎 Deploy Preview https://deploy-preview-2832--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good idea!

@bdbch bdbch merged commit 50083f3 into ueberdosis:main Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants