feat: Allow multiple prefix characters to trigger a suggestion #2896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rfgamaral
force-pushed
the
multiple-suggestion-prefixes
branch
5 times, most recently
from
ec4f28f
to
74f9588
Compare
|
@bdbch Any clue why Netlify deployment is failing? |
|
@rfgamaral we had the same issue. Seems like Netlify cached something and now doesn't like new builds. I'll hit up a fresh run for this PR! :) |
|
I manually triggered a build: The PR looks fine to me. |
bdbch
reviewed
Jun 20, 2022
bdbch
approved these changes
Jun 20, 2022
rfgamaral
force-pushed
the
multiple-suggestion-prefixes
branch
from
74f9588
to
9d7a8d7
Compare
bdbch
approved these changes
Jun 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the
prefixSpaceoption in theSuggestionutility with a new, more flexible option,allowedPrefixes. This option accepts multiple characters in a string, and allows each one of those characters as a prefix when triggering suggestions.The current
prefixSpaceoption is not very flexible, only allowing spaces as the prefix character, or everything else. But we are in the need of something more flexible, where we only allow a certain set of characters to be prefixed before the suggestion trigger character (i.e.@for the mention extension).The idea here is that we can configure this option to work more like GitHub. For instance, setting
allowedPrefixes: ' ([', suggestions can be triggered if the prefix character is(or[. The default isallowedPrefixes: null, disables the option, and any character is allowed to be a prefix (same as settingprefixSpace: falsein the current implementation).I've also added
allowedPrefixesto theSuggestionutility documentation, whereasprefixSpacewas currently missing.