Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(extension-link): Change autolink to only apply after breaking a word #3232

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

C-Hess
Copy link
Contributor

@C-Hess C-Hess commented Sep 25, 2022

Made a change to the autolink plugin for extension-link to only autolink after hitting space, which is a more common behavior on WYSIWYG editors. I wanted to also remove the auto-"unlinking" feature, as this is also not a common behavior, but I figured I wouldn't change this in this PR unless requested

Fix #3225

@netlify
Copy link

netlify bot commented Sep 25, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit ef3fc20
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/632fa9e7e9fba0000895fe13
😎 Deploy Preview https://deploy-preview-3232--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch self-requested a review September 26, 2022 09:06
Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Looks good to me. Nice.

@bdbch bdbch merged commit 8f5fbef into ueberdosis:main Sep 26, 2022
@xiaweiss
Copy link

@C-Hess I found a bug here: #3254

I add an if to skip undefined, can you review it?

@C-Hess C-Hess deleted the feature/link-on-space branch October 27, 2022 08:05
@C-Hess C-Hess restored the feature/link-on-space branch October 27, 2022 08:05
@C-Hess C-Hess deleted the feature/link-on-space branch October 27, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autolinking links should only trigger after hitting space
4 participants