Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup linkifyjs when the editor is destroyed #3316

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

educastellano
Copy link
Contributor

@educastellano educastellano commented Oct 17, 2022

I was getting these warnings after pasting links and then destroying and creating a new editor again:

linkifyjs: already initialized - will not register custom protocol "ftp" until you manually call linkify.init(). 
To avoid this warning, please register all custom protocols before invoking linkify the first time.

With the extension being called like this:

Link.configure({
  protocols: ['ftp', 'mailto']
})

Resetting linkifyjs when the editor is destroyed fixes this.

@netlify
Copy link

netlify bot commented Oct 17, 2022

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 07046a6
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/634d1f452d6c890008b8ec55
😎 Deploy Preview https://deploy-preview-3316--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@bdbch bdbch merged commit 1c493f3 into ueberdosis:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants