chore: allow new ReactComponentContent components to be created #3782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
svenadlung
reviewed
Feb 26, 2023
There was a problem hiding this comment.
Not changing cursor position will be fixed with #3781, correct?
Hitting Mod + Enter in the middle of content splits content and adds another node – is it the desired behaviour? Anyways, it's just for demonstration purpose.
Exactly. #3781 fixes the cursor issue. And yes the demo could be improved, but for now it's usable to test the cursor positioning issue. |
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
…rdosis#3782) * chore: allow users to create new react nodeview editor content components * style: remove trailing spaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside the
ReactComponentContentnode view demo there was no way to add new components to test cursor behavior. This adds this functionality by usingMod+Enter.This is related to #3781 as it was used to test the functionality this way.