fix: update typings for node view decorations #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
svenadlung
requested changes
Feb 26, 2023
There was a problem hiding this comment.
Please check tests:
Error: Webpack Compilation Error
[tsl] ERROR in /home/runner/work/tiptap/tiptap/packages/core/src/NodeView.ts(41,5)
TS2322: Type 'Decoration[]' is not assignable to type 'DecorationWithType[]'.
Type 'Decoration' is not assignable to type 'DecorationWithType'.
Property 'type' is missing in type 'Decoration' but required in type '{ type: NodeType; }'.
aliasliao
pushed a commit
to aliasliao/tiptap
that referenced
this pull request
May 24, 2023
* fix: update typings for node view decorations * fix(core): update types for NodeView * fix(core): declare props.decorations as decorationWithType
andrewlu0
pushed a commit
to trybaseplate/tiptap
that referenced
this pull request
Oct 20, 2023
* fix: update typings for node view decorations * fix(core): update types for NodeView * fix(core): declare props.decorations as decorationWithType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should close #3772 by adding a new type called
DecorationWithTypewhich includes the defaultDecorationtype coming from@tiptap/pm/viewbut includes the NodeType.This way people can access the
decoration.typeproperty without experiencing typing issues.