Add support for custom selection builders #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@bdbch Can you please take a look? |
bdbch
requested changes
Jul 7, 2023
There was a problem hiding this comment.
nice one! could you add the new selectionRender option to the docs too? @benglewis
|
@bdbch I've added the property to the documentation. Hopefully I understood how to do it correctly. |
|
@bdbch please, merge and release this request 🙇🏻♂️ |
|
@bdbch Any updates regarding this merge? 🙏 |
|
Hi @svenadlung @bdbch , Is there any chance that you can please review and merge this PR? 🙏 |
bdbch
approved these changes
Aug 3, 2023
benglewis
deleted the
extension-collaboration-cursor-custom-cursor-builder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
Add support for custom selection builders.
How did you accomplish your changes
Added new field to the extension options, type and passing along parameter to the
y-prosemirrorextension. Passing by default the existing default value to avoid breaking anything.How have you tested your changes
Ran the existing collaboration demo locally with the changes applied. Verified that the cursor and selection is shown correctly.
How can we verify your changes
You can clone code and check that the collaboration cursor and selection is not broken.
Remarks
N/A
Checklist