Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lists): move list keymap to extra extension #4290

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

bdbch
Copy link
Contributor

@bdbch bdbch commented Aug 5, 2023

Please describe your changes

Because our custom keymap handling could potentially break when Prosemirror gets updated we decided to not have any custom fixes for that in our core but move it to an extra extension that can be loaded if the default keymap of Prosemirror is not sufficient.

This way we can also avoid breaking the core editing behaviour because of potential bugs in those custom fixes.

How did you accomplish your changes

Moved all of the keymap handling into it's own extension

How have you tested your changes

I created local demos - if you want to test it:

  1. Check it out
  2. Create a custom demo locally from taskList, bulletList or orderedlist
  3. Add the ListKeymap extension
  4. Check if the custom keymap handlers are triggered

Remarks

This is crucical to finally release a new stable version (2.1.0) as I don't want those keymaps in the core in 2.1.0

Checklist

  • The changes are not breaking the editor
  • Followed the guidelines
  • Fixed linting issues

@bdbch bdbch requested a review from svenadlung as a code owner August 5, 2023 22:18
@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit ac8def8
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/64cecd0f7e1f4c000851159e
😎 Deploy Preview https://deploy-preview-4290--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@bdbch bdbch mentioned this pull request Aug 6, 2023
2 tasks
@bdbch bdbch merged commit 7e7057e into develop Aug 10, 2023
15 checks passed
@bdbch bdbch deleted the bdbch/list-keymap-extension branch August 10, 2023 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant