Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(suggestion): unused parameter oldState in apply. #4771

Merged
merged 1 commit into from
May 23, 2024

Conversation

remyma
Copy link
Contributor

@remyma remyma commented Jan 10, 2024

Please describe your changes

Ignore unused parameter in suggestion plugin during typescript build.

How have you tested your changes

Add this typescript compiler option

{
  "compilerOptions": {
    ...
    "noUnusedParameters": true,
   ...
  },
  ...

Build project, it should build fine with suggested code changed.

npm --prefix ./packages/suggestion run build

Before the change this results in error:

[!] (plugin rpt2) Error: /home/marem/developpement/tiptap/packages/suggestion/src/suggestion.ts(187,32): semantic error TS6133: 'oldState' is declared but its value is never read.

After the change build is be ok.

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

#4770

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 6b35bcf
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/659f264e80d3f30008e60100
😎 Deploy Preview https://deploy-preview-4771--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nperez0111 nperez0111 merged commit 393d83e into ueberdosis:develop May 23, 2024
4 checks passed
@nperez0111 nperez0111 mentioned this pull request Jul 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants