fix: Disallow only whitespace between markdown shortcuts delimiters #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tiptap-embed ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
force-pushed
the
ricardo/better-marks-regexs
branch
3 times, most recently
from
aea5f6e
to
120dffb
Compare
rfgamaral
force-pushed
the
ricardo/better-marks-regexs
branch
from
120dffb
to
b1882e9
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe your changes
This PR disallows Markdown shortcuts (through typing or pasting) for all marks (
Bold,Code,Highlight,Italic, andStrike) when the content between the delimiters is only whitespace.How did you accomplish your changes
Changed the input and paste Regex for all the marks mentioned above to keep supporting as much as possible from the current syntax, while only disallowing "empty strings" between the delimiters for the Markdown shortcuts of each mark.
Note
The regular expression for all marks follows the exact same pattern, the only difference being the delimiter characters for each mark.
How have you tested your changes
I've used both regex101.com:
And the marks demos to test multiple patterns, here's an example for the
Highlightextension:How can we verify your changes
The same way I did above.