Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mark nocookie youtube url as valid when parsing html #4883

Merged
merged 1 commit into from Feb 19, 2024

Conversation

LukasHirt
Copy link
Contributor

@LukasHirt LukasHirt commented Feb 13, 2024

Please describe your changes

Extended the YOUTUBE_REGEX in youtube extension to consider nocookie URL as valid.

How did you accomplish your changes

Added youtube-nocookie\.com into the regex.

How have you tested your changes

Locally via link to my app and added automated tests.

How can we verify your changes

Set content of the editor to e.g.

<div data-youtube-video=""><iframe class="w-full aspect-video" width="640" height="480" allowfullscreen="true" autoplay="false" disablekbcontrols="false" enableiframeapi="false" endtime="0" ivloadpolicy="0" loop="false" modestbranding="false" origin="" playlist="" src="https://www.youtube-nocookie.com/embed/dh72Dz0OqLk" start="0"></iframe></div>

Remarks

[add any additional remarks here]

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

[add a link to the related issues here]

Copy link

netlify bot commented Feb 13, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit d684560
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/65cb6352fa6aff00083446fe
😎 Deploy Preview https://deploy-preview-4883--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@bdbch bdbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdbch bdbch merged commit 099e10d into ueberdosis:main Feb 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants