Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "extension/link: adds 'whenNotEditable' as option for openOnClick" #5040

Merged
merged 2 commits into from
May 24, 2024
Merged

Revert "extension/link: adds 'whenNotEditable' as option for openOnClick" #5040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60aa120
Revert "extension/link: adds 'whenNotEditable' as option for openOnCl…
benkroeger Apr 8, 2024
7c6a2ce
Merge branch 'main' into revert-3312-main
nperez0111 May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 0 additions & 8 deletions docs/api/marks/link.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,14 +65,6 @@ Link.configure({
})
```

If set to `'whenNotEditable'`, links will be opened on click only when editor is not editable.

```js
Link.configure({
openOnClick: 'whenNotEditable',
})
```

### linkOnPaste
Adds a link to the current selection if the pasted content only contains an url.

Expand Down
6 changes: 1 addition & 5 deletions packages/extension-link/src/helpers/clickHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,18 +3,14 @@ import { MarkType } from '@tiptap/pm/model'
import { Plugin, PluginKey } from '@tiptap/pm/state'

type ClickHandlerOptions = {
type: MarkType,
whenNotEditable: boolean,
type: MarkType
}

export function clickHandler(options: ClickHandlerOptions): Plugin {
return new Plugin({
key: new PluginKey('handleClickLink'),
props: {
handleClick: (view, pos, event) => {
if (options.whenNotEditable && view.editable) {
return false
}
if (event.button !== 0) {
return false
}
Expand Down
3 changes: 1 addition & 2 deletions packages/extension-link/src/link.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export interface LinkOptions {
* @example false
* @example 'whenNotEditable'
*/
openOnClick: boolean | 'whenNotEditable'
openOnClick: boolean
/**
* Adds a link to the current selection if the pasted content only contains an url.
* @default true
Expand Down Expand Up @@ -264,7 +264,6 @@ export const Link = Mark.create<LinkOptions>({
plugins.push(
clickHandler({
type: this.type,
whenNotEditable: this.options.openOnClick === 'whenNotEditable',
}),
)
}
Expand Down