Text Align Extension: issue with DOM update when multiple types exist and not every exist at the DOM of the editor.

[echatzief]

…

Please describe your changes

I have changed the setTextAlign and unsetTextAlign because if you used multiple types lets say ['heading', 'paragraph'] and at the DOM of the editor we only have a paragraph only no heading. Then when we call setTextAlign then it will go the the every loop and at the first try to updateAttributes for heading it will fail and it will stop there an the paragraph won't update because that how the every loop works. It stops on the first falsy value. Same happens for the unsetTextAlign function

How did you accomplish your changes

I changed the setTextAlign and unsetTextAlign to use a map to go through every update and then validate the updates. That how we avoid the bug described above

How have you tested your changes

Yes. I have tested locally with a Vue3 project

How can we verify your changes

Try the scenario that we described.

Checklist

• The changes are not breaking the editor
• Added tests where possible
• Followed the guidelines
• Fixed linting issues

[netlify]

✅ Deploy Preview for tiptap-embed ready!

Name	Link
🔨 Latest commit	5461d43
🔍 Latest deploy log	https://app.netlify.com/sites/tiptap-embed/deploys/663123d3302a330008911e82
😎 Deploy Preview	https://deploy-preview-5097--tiptap-embed.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[nperez0111]

This looks right to me

[bdbch]

Nice change. LGTM!

[echatzief]

If it looks good then merge it 😀

[bdbch]

@echatzief sometimes we wait for another maintainer to also take a look