Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make EditorProvider children optional #5102

Merged
merged 3 commits into from
May 9, 2024
Merged

Conversation

hjoelh
Copy link
Contributor

@hjoelh hjoelh commented Apr 29, 2024

Please describe your changes

fixes issue 1 of #4618

How did you accomplish your changes

[add a detailed description of how you accomplished your changes here]

How have you tested your changes

can't see any reason for it to be required

How can we verify your changes

[add a detailed description of how we can verify your changes here]

Remarks

[add any additional remarks here]

Checklist

  • The changes are not breaking the editor
  • Added tests where possible
  • Followed the guidelines
  • Fixed linting issues

Related issues

#4618

Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for tiptap-embed ready!

Name Link
🔨 Latest commit 70f68dc
🔍 Latest deploy log https://app.netlify.com/sites/tiptap-embed/deploys/663356bec2fd95000850b955
😎 Deploy Preview https://deploy-preview-5102--tiptap-embed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hjoelh hjoelh marked this pull request as ready for review May 2, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants