Text Color and Background extensions, and additional supporting of the "type" attribute to OrderedList #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding Text Color Extension
Adding Text BackgroundColor extension
Adding a supporting of the "type" attribute to OrderedList
Joost-dm
changed the title
Joost-dm
changed the title
|
Thanks for your work on this @Joost-dm! We’ll add support for background-color and color to tiptap v2. 🙌 I’m not sure about the type option for OrderedLists, but it’ll definitely easier to add this with v2 for everyone who wants to do it. It’ll make a great example for the documentation. So thank you very much! If you don’t mind: For maintainers it’s way easier to have multiple small PRs for features, than one PR with multiple features. It’s easier to look through and it’s easier to merge one by one. Have a nice day, and thanks again for your contribution! 💖 Oh, and I added it to the list of community extensions: #819 ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Text Color and Background extensions, and additional supporting of the "type" attribute of
to OrderedList =)