Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the service visibility for Symfony 4 #140

Merged
merged 1 commit into from
Aug 13, 2018
Merged

Fix the service visibility for Symfony 4 #140

merged 1 commit into from
Aug 13, 2018

Conversation

francoispluchino
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

Fix the visibility of the uecode_qpush service with Symfony 4 Flex. This alias is used by the commands using the $container->get() method and require the public visibility otherwise this exception is thrown:

[Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException]
The "uecode_qpush" service or alias has been removed or inlined when the container was compiled. You should either make it public, or stop using the container directly and use dependency injection instead. 

@scrutinizer-notifier
Copy link

The inspection completed: 2 new issues

@francoispluchino
Copy link
Contributor Author

Note: The 2 Scrutinizer issues are for code duplication of 2 commands and not for this PR.

@francoispluchino
Copy link
Contributor Author

Can you merge this PR?

@francoispluchino
Copy link
Contributor Author

@kmfk Can you merge this PR and create a new tag?

@k-k k-k merged commit cf45402 into uecode:master Aug 13, 2018
@francoispluchino
Copy link
Contributor Author

@kmfk Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants