Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PkPass diffing for change messages #53

Open
ueman opened this issue Jul 1, 2024 · 0 comments
Open

PkPass diffing for change messages #53

ueman opened this issue Jul 1, 2024 · 0 comments
Labels
package: passkit Issues relevant for the "passkit" package

Comments

@ueman
Copy link
Owner

ueman commented Jul 1, 2024

When a PkPass file is updated, the system is supposed to show a change message notification/hint (depending on whether it was updated in background/foreground).
This is done by comparing the fields of the old and updated pass.

Those fields with a change message should be returned with a properly formatted change message. Otherwise, a generic message should be returned.

An open question is whether those fields support localization, but I would assume so.

We could provide an API that looks something like this:

class PkPass {
  List<String> getChangeMessages(PkPass oldPass, String locale) {
    // ...
  }
}

final changeMessages = newPass.getChangeMessages(oldPass, 'de_DE');
@ueman ueman added the package: passkit Issues relevant for the "passkit" package label Jul 1, 2024
@ueman ueman changed the title PkPass diffing PkPass diffing for change messages Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: passkit Issues relevant for the "passkit" package
Projects
None yet
Development

No branches or pull requests

1 participant