Add Key#expires? and fix SubKey#expires #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add SubKey#expires? Returns true if the subkey has an expiration date, else false - Fix SubKey#expires Returns nil if the key has no expiration date - Add Key#expires? Returns true if the key has an expiration data, else false
ushis
changed the title
ueno
added a commit
that referenced
this pull request
Sep 16, 2014
Add Key#expires? and fix SubKey#expires
|
nice cleanup, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, i made some minor changes to the Key API. Please let me know, what you think about it.
Add SubKey#expires?
Returns true if the subkey has an expiration date, else false
Fix SubKey#expires
Returns nil if the key has no expiration date
Add Key#expires?
Returns true if the key has an expiration date, else false