Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component signals should fail if no component with the provided ID exists #3605

Closed
Wesselvdp opened this issue Dec 13, 2023 · 0 comments
Closed

Comments

@Wesselvdp
Copy link
Contributor

Wesselvdp commented Dec 13, 2023

  1. consider this signal:
- signal: component/CALL
  component: uesio/io.table
  componentsignal: TOGGLE_MODE
  targettype: specific
  componentid: myCoolTable
  1. This will add an item to the component slice for myCoolTable.
  2. When there is no component with uesio.id: myCoolTable. Nothing will happen visually, but the signal's statechange persists in redux nonetheless.

The problem with the above is that when you misspelled the on the component or the signal, or it's not set at all. The user will need to debug himself.

Solution:

  1. Add an error notification to inform the user of the missing signal target

Additional thought:
Just to challenge the solution above, could it be useful to send signals to a component state that doesn't exist but you know it will later? Like a steppable form, the user might want to send signals in order to save data to step state before it's rendered.

┆Issue is synchronized with this Clickup task by Unito

@Wesselvdp Wesselvdp self-assigned this Dec 13, 2023
@ghost ghost assigned ghost and unassigned Wesselvdp and ghost Dec 15, 2023
@humandad humandad closed this as completed Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants