[REQ] only translate "foreign" text #29

gingerbeardman · 2018-08-05T21:36:19Z

It would be great if the extension only translated "foreign" text

ideas:

pages that have a different locale than target translation language (or user Safari/macOS locale?)
if translation output is the same as input

devemio · 2018-08-06T11:27:54Z

To implement this we can retrieve the detected language from Google API and check with our targetLanguage. But in this case we shouldn't dispatch message showPanel with loading icon first. In other words, we first need to translate the text and then decide whether to show the panel or not. Perhaps there is another good solution to determine the language of the selected text on the extension side.

gingerbeardman · 2018-08-06T12:21:19Z

To get the language of the page we have the following:

HTML lang (cf HTML spec)
<html lang="ja-JP"...
META charset (cf HTML spec)
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8"...
META locale (cf Facebook)
<meta property="og:locale" content="ja_JP"...

If testing those disables and the user still wants to translate they can use the context menu.

To detect user language:

navigator.language (language of browser app?)
navigator.languages (users preferred languages?)
(these are sometimes the same but not always)

There's also Window.onlanguagechange to take care of.

uetchy · 2018-08-07T03:19:30Z

Yes. We need to do something for this.

However, language detection is inefficient because ...

Not all site admins follow the rule (some site mistakenly points to inappropriate language)
Detecting a language using APIs takes a large amount of network requests
Doing language detection without showing loading indicator bring it with the loss of UX.

Instead of those, how about we'd offer a toolbar button (and key shortcut) for switching instant translation feature?

gingerbeardman · 2018-08-07T07:40:23Z

That doesn't solve the problem IMHO.

Maybe an option to switch off language detection for Instant Translation?

devemio · 2018-08-08T14:15:39Z

Using the API to define the language brings a lot of extra network requests.

I think that some kind of shortcut would be a good idea to switch instant translation feature.

gingerbeardman · 2018-08-08T14:47:40Z

I'm working on this one :)

gingerbeardman · 2018-08-08T23:29:36Z

Just putting some thoughts down...

If we try to simplify the goal: what do we really want to do?

Check if the language of the text/page is the same as the target language.
We don't actually need to know what it is, Google Translate can figure that out.

function getPageLanguage() {
  var langHTML = document.documentElement.lang

  var langCharSet = document.characterSet

  var x = document.getElementsByTagName("META")
  for (var i = 0; i < x.length; i++) {
    if (x[i].getAttribute('property') == 'og:locale')
      var langOgLocale = x[i].getAttribute('content')
  }

  if (langHTML != null) console.log(langHTML)
  if (langCharSet != null) console.log(langCharSet)
  if (langOgLocale != null) console.log(langOgLocale)
  if (langClosest != null) console.log(langClosest)

  return
}

URL	lang	characterSet	og:locale
https://www.github.com	en	UTF-8	–
https://www.hbo.com/about/faqs	en	UTF-8	–
https://www.bbc.co.uk/cymrufyw	cy	UTF-8	cy_GB
https://www.jp.playstation.com	ja-JP	UTF-8	ja_JP
https://ja.wikipedia.org/wiki/富士山	ja	UTF-8	–
http://www.jah.ne.jp/~hanhan4/imasara/8lakes/	–	EUC-JP	–

Maybe it's enough to just check lang? Benefit is that it is the same format as the languages are stored in Settings.plist

There's also a possibility that elements within the page are given a lang attribute, so it's better to start at the click and go up the DOM to the closest lang attribute.

var langClosest = e.closest('[lang]').attr('lang') //closest lang attribute wrapping what was clicked

What if our logic gets it wrong? The user still sees the translation! No worries.

uetchy · 2018-08-09T03:42:16Z

Thank you for the detailed survey!

I think this feature could be shipped if the following issues were solved.

For English speakers, they may have a problem with translating Chinese contents in GitHub because lang in their page indicates 'en' and thus Polyglot won't reveal a translation.
Relating to the above, all web service which provides user-generated contents have a similar issue. so at least we should make this feature optional.

Consider filing PR for this feature! so we can test it in the real world whether it works well 👍

gingerbeardman · 2018-08-09T07:49:44Z

Agreed. This is a difficult problem to solve satisfactorily. I will give it more thought.

gingerbeardman · 2019-07-08T09:49:13Z

I was thinking it is possible to guess encoding of text using JavaScript or Obj-C (now that the extension is native) with quick initial check to see if it only contains ASCII bytes.

Background
https://unicodebook.readthedocs.io/guess_encoding.html

JavaScript
https://github.com/aadsm/jschardet

Obj-C (Foundation)
https://developer.apple.com/documentation/foundation/nsstring/1413576-stringencodingfordata?language=objc

stale · 2019-09-06T10:22:45Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

gingerbeardman · 2019-09-06T11:22:32Z

Let's still do this.

gingerbeardman · 2020-03-16T11:53:43Z

I still run into this problem.

I think perhaps my issues would mostly be solved switching off Polyglot for contents of input/textarea?

uetchy · 2020-03-18T10:51:09Z

Putting "On/off" toggle switch inside textarea (as Grammarly does) is one of our options.

gingerbeardman · 2020-03-18T10:53:02Z

I will look into how that works.

AntonUspishnyi · 2020-08-12T11:11:05Z

Hi there.
I have Safari in English, but I want translate English to Russian?
How can I do this?

gingerbeardman · 2020-08-12T11:19:36Z

@AntonUspehov did you set your preferences in the Polyglot app?

See readme > setup > step 3

gingerbeardman · 2020-09-09T09:17:32Z

This issue still annoys me every day.

How about disabling Polyglot for certain domains? For me that would be English Wikipedia for example.

uetchy · 2021-01-25T05:20:18Z

doing quick experiment. mostly working fine though.

gingerbeardman · 2021-02-26T12:29:52Z

This does not work reliably for me?

eg. in my eBay.co.uk messages I select part of a message and that triggers Polyglot?

gingerbeardman changed the title ~~[REQ] only translate foreign text~~ [REQ] only translate "foreign" text Aug 5, 2018

uetchy added enhancement good first issue labels Aug 6, 2018

gingerbeardman mentioned this issue Jul 8, 2019

Polyglot 3 #30

Closed

5 tasks

uetchy added this to To do in Polyglot 3 Jul 9, 2019

uetchy removed this from To do in Polyglot 3 Jul 16, 2019

stale bot added the wontfix label Sep 6, 2019

stale bot removed the wontfix label Sep 6, 2019

uetchy removed the good first issue label Sep 25, 2019

gingerbeardman mentioned this issue Dec 24, 2019

[REQ] Button to hide popup without deselecting text #72

Open

uetchy mentioned this issue Jan 27, 2021

Release 3.3.0 #89

Merged

uetchy closed this as completed in #89 Jan 27, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[REQ] only translate "foreign" text #29

[REQ] only translate "foreign" text #29

gingerbeardman commented Aug 5, 2018 •

edited

Loading

devemio commented Aug 6, 2018

gingerbeardman commented Aug 6, 2018 •

edited

Loading

uetchy commented Aug 7, 2018

gingerbeardman commented Aug 7, 2018

devemio commented Aug 8, 2018

gingerbeardman commented Aug 8, 2018

gingerbeardman commented Aug 8, 2018 •

edited

Loading

uetchy commented Aug 9, 2018

gingerbeardman commented Aug 9, 2018

gingerbeardman commented Jul 8, 2019 •

edited

Loading

stale bot commented Sep 6, 2019

gingerbeardman commented Sep 6, 2019 •

edited

Loading

gingerbeardman commented Mar 16, 2020

uetchy commented Mar 18, 2020

gingerbeardman commented Mar 18, 2020

AntonUspishnyi commented Aug 12, 2020

gingerbeardman commented Aug 12, 2020 •

edited

Loading

gingerbeardman commented Sep 9, 2020 •

edited

Loading

uetchy commented Jan 25, 2021

gingerbeardman commented Feb 26, 2021

[REQ] only translate "foreign" text #29

[REQ] only translate "foreign" text #29

Comments

gingerbeardman commented Aug 5, 2018 • edited Loading

devemio commented Aug 6, 2018

gingerbeardman commented Aug 6, 2018 • edited Loading

uetchy commented Aug 7, 2018

gingerbeardman commented Aug 7, 2018

devemio commented Aug 8, 2018

gingerbeardman commented Aug 8, 2018

gingerbeardman commented Aug 8, 2018 • edited Loading

uetchy commented Aug 9, 2018

gingerbeardman commented Aug 9, 2018

gingerbeardman commented Jul 8, 2019 • edited Loading

stale bot commented Sep 6, 2019

gingerbeardman commented Sep 6, 2019 • edited Loading

gingerbeardman commented Mar 16, 2020

uetchy commented Mar 18, 2020

gingerbeardman commented Mar 18, 2020

AntonUspishnyi commented Aug 12, 2020

gingerbeardman commented Aug 12, 2020 • edited Loading

gingerbeardman commented Sep 9, 2020 • edited Loading

uetchy commented Jan 25, 2021

gingerbeardman commented Feb 26, 2021

gingerbeardman commented Aug 5, 2018 •

edited

Loading

gingerbeardman commented Aug 6, 2018 •

edited

Loading

gingerbeardman commented Aug 8, 2018 •

edited

Loading

gingerbeardman commented Jul 8, 2019 •

edited

Loading

gingerbeardman commented Sep 6, 2019 •

edited

Loading

gingerbeardman commented Aug 12, 2020 •

edited

Loading

gingerbeardman commented Sep 9, 2020 •

edited

Loading