Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyglot 3 #30

Closed
5 tasks done
uetchy opened this issue Aug 6, 2018 · 21 comments
Closed
5 tasks done

Polyglot 3 #30

uetchy opened this issue Aug 6, 2018 · 21 comments

Comments

@uetchy
Copy link
Owner

uetchy commented Aug 6, 2018

Mac App Store version of Polyglot.

Current status

Shipped.

Remaining Tasks

  • Rewrite global script codebase in Swift
  • Rewrite content scripts to communicate with Swift extension handler.
  • Toolbar Icon
  • Context menu

Future work

  • Synonyms support
@uetchy uetchy self-assigned this Aug 6, 2018
@uetchy
Copy link
Owner Author

uetchy commented Aug 6, 2018

The document for migrating from legacy extensions: https://developer.apple.com/documentation/safariservices/safari_app_extensions/converting_a_legacy_safari_extension_to_a_safari_app_extension

Safari Extension development guide:
https://developer.apple.com/documentation/safariservices/safari_app_extensions/building_a_safari_app_extension

@uetchy
Copy link
Owner Author

uetchy commented Jan 17, 2019

Sadly, I have been away and don't have a chunk of time enough.
If someone is willing to contribute into Swift & Safari App Extension impl., it would be much appreciated! ☺️

The current code base is placed on mas branch.

@gingerbeardman
Copy link
Collaborator

I think it's fairly low priority until Safari Extension gallery source is retired (WWDC/June? Public/October?

@uetchy uetchy pinned this issue Mar 10, 2019
@uetchy uetchy added this to To do in Polyglot 3 Jun 5, 2019
@uetchy uetchy moved this from To do to In progress in Polyglot 3 Jun 5, 2019
@uetchy uetchy moved this from In progress to To do in Polyglot 3 Jul 1, 2019
@uetchy uetchy moved this from To do to In progress in Polyglot 3 Jul 1, 2019
@uetchy
Copy link
Owner Author

uetchy commented Jul 6, 2019

Finally. About to ship this month.

Screen Shot 2019-07-07 at 3 36 23

@uetchy
Copy link
Owner Author

uetchy commented Jul 6, 2019

Screen Shot 2019-07-07 at 4 52 04

Screen Shot 2019-07-07 at 4 52 38

Upcoming dark/light mode and vibrancy support.

@uetchy uetchy changed the title Polyglot for Mac App Store Polyglot 3 Jul 7, 2019
@uetchy
Copy link
Owner Author

uetchy commented Jul 7, 2019

Pre-release version is out!
Leave a comment if you find a glitch.

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jul 7, 2019

Great work!

A few issues...

  1. I am seeing bad encoding on translated result when set to Auto Detect:

http://www.katch.ne.jp/~guts-2t86/game6.html
Screen shot 2019-07-07 at 11 13 56

http://sekaiyugi.com/games/hanafuda-1.html
Screen shot 2019-07-07 at 11 14 56

If I set Source Language to Japanese, display works OK:
Screen shot 2019-07-07 at 11 18 00

  1. BUT... translated text seems incorrect? seems to be coming from a source that is not the selected text or current window?

Compare Polyglot 2.6.0
Screen shot 2019-07-07 at 11 19 26

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jul 7, 2019

  1. there is no way to bring Polyglot.app window back if it is closed using red dot. This will result in failed MAS submission in my experience with other Safari App Extensions.

Recommended solution: quit app on window close.

@uetchy
Copy link
Owner Author

uetchy commented Jul 7, 2019

@gingerbeardman Thank you for the super fast review!
Just fixed the Unicode related issue and updated pre-release tag. It should work now.

@uetchy
Copy link
Owner Author

uetchy commented Jul 7, 2019

Recommended solution: quit app on window close.

Added to ToDo

@gingerbeardman
Copy link
Collaborator

Good Job!

Screen shot 2019-07-07 at 16 30 37

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jul 7, 2019

Added to ToDo

AppDelegate.swift:

func applicationShouldTerminateAfterLastWindowClosed(_ sender: NSApplication) -> Bool {
    return true
}

edit: ah, you already did it!

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jul 7, 2019

Problem reading text over dark background.
Screen shot 2019-07-07 at 20 31 34

Workaround is to select translated text
Screen shot 2019-07-07 at 20 31 29

@uetchy
Copy link
Owner Author

uetchy commented Jul 8, 2019

@gingerbeardman put more opacity on the panel. try the latest build and see if the issue is fixed.

@uetchy
Copy link
Owner Author

uetchy commented Jul 8, 2019

Screen Shot 2019-07-08 at 16 37 27

Screen Shot 2019-07-08 at 16 37 45

The latest build contains "synonyms" feature that displays related words during single word lookups.

@gingerbeardman
Copy link
Collaborator

Even better than ever!

@gingerbeardman
Copy link
Collaborator

Possible to catch some of the outstanding issues? Such as #29

@gingerbeardman
Copy link
Collaborator

gingerbeardman commented Jul 8, 2019

Synonym feature display seems small for me?

Screen shot 2019-07-08 at 11 35 15

@uetchy
Copy link
Owner Author

uetchy commented Jul 9, 2019

I won't fix #29 in this release because there are some difficulties lying down (e.g. difficulties on precise language detection and false negatives)

@uetchy
Copy link
Owner Author

uetchy commented Jul 9, 2019

new build includes fixes on the font-size issue.

@uetchy uetchy moved this from In progress to Review in progress in Polyglot 3 Jul 9, 2019
@uetchy uetchy moved this from Review in progress to Done in Polyglot 3 Jul 11, 2019
@uetchy
Copy link
Owner Author

uetchy commented Jul 11, 2019

Polyglot 3 is now available at Mac App Store and mas branch has been merged into master 🚀
Huge thanks to all the contributors involved in this issue and Polyglot.

@uetchy uetchy closed this as completed Jul 11, 2019
@uetchy uetchy unpinned this issue Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Polyglot 3
  
Done
Development

No branches or pull requests

2 participants