Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if magnetometer calibration is necessary after thruster swaps #196

Closed
duggerdufl opened this issue Jan 26, 2017 · 8 comments
Closed

Comments

@duggerdufl
Copy link
Member

Are the manufacturing differences in each new thruster enough to affect the magnetometer calibration?

@sentree
Copy link
Member

sentree commented Jan 31, 2017

Were the new thrusters in use at the last pool day? The sub was very stable near the end.

@duggerdufl
Copy link
Member Author

Through testing it does not look like anything is being severely affected. There might be some small changes that we can not see through observation.

Here is some notes on it from uf-mil-archive: https://github.com/uf-mil-archive/getting-started/blob/master/magnetic-calibration.md

@forrestv Can you comment on this (you wrote that document)?

@sentree
Copy link
Member

sentree commented Jan 31, 2017

Looking at the text, it appears that it is able to also account for the metal in the sub. Perhaps we should wait until the new chassis is built and assembled to do a full calibration.

@duggerdufl
Copy link
Member Author

Looks like only hardsoft calibrations are being applied, per https://github.com/uf-mil/Sub8/blob/master/command/sub8_launch/launch/subsystems/nav_box.launch

@mattlangford
Copy link
Member

mattlangford commented Feb 1, 2017

According to that launch it looks like the dynamic is being applied as well
from imu -- /imu/mag_raw --> [dynamic compensation] -- /imu/mag_lessraw --> [hardsoft compensation] -- /imu/mag --> UKF

@duggerdufl
Copy link
Member Author

You're correct - I don't have a good understanding of launch files, saw the remap and just assumed it did that without changing anything.

@forrestv
Copy link
Member

forrestv commented Feb 1, 2017

The dynamic compensation may be running, but AFAIK it's not doing anything since the thruster drivers don't publish their magnetic field contributions like the Sub7 thruster drivers did. If nothing is being published on /imu/mag_generated_info, that would confirm this. Given that, it's safe to remove from the launch file (though you'd have to keep everything connected by changing the remaps).

So, dynamic compensation is a no-op.

The hard/soft calibration should still be done any time anything near the magnetometer changes and ideally whenever anything metal anywhere on the sub changes.

@mattlangford
Copy link
Member

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants