Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Postprocessing bug #20

Closed
tomasmcz opened this issue Jun 23, 2016 · 2 comments
Closed

Postprocessing bug #20

tomasmcz opened this issue Jun 23, 2016 · 2 comments
Assignees
Labels

Comments

@tomasmcz
Copy link
Member

tomasmcz commented Jun 23, 2016

When I ran my tests/small.ini configuration, it failed on some error with lambda wanting two arguments, but just one was given. I solved this in my branch by removing the second (unused) argument of the lambda on line 36 in learning_utils, but I'm not sure whether this does not break anything else. Can you have a look at this, @jindrahelcl?

Edit: The correct lambda was on line 155, but maybe they should be the same?

@tomasmcz
Copy link
Member Author

Here is the traceback:

Traceback (most recent call last):

  File "/opt/python/2.7.10/lib/python2.7/runpy.py", line 162, in _run_module_as_main

    "__main__", fname, loader, pkg_name)

  File "/opt/python/2.7.10/lib/python2.7/runpy.py", line 72, in _run_code

    exec code in run_globals

  File "/home/travis/build/ufal/neuralmonkey/neuralmonkey/train.py", line 149, in <module>

    main()

  File "/home/travis/build/ufal/neuralmonkey/neuralmonkey/train.py", line 142, in main

    minimize_metric=args.minimize)

  File "neuralmonkey/learning_utils.py", line 194, in training_loop

    val_tgt_sentences = postprocess(val_raw_tgt_sentences)

TypeError: <lambda>() takes exactly 2 arguments (1 given)

@jindrahelcl
Copy link
Member

jindrahelcl commented Jun 24, 2016

Yeah, that's OK. I was removing the second argument which was the whole dataset and which was unused everywhere else, but I did not try that without a postprocessor. Merge this to master, please.

@tomasmcz tomasmcz mentioned this issue Jun 28, 2016
carolinlawrence pushed a commit to carolinlawrence/neuralmonkey that referenced this issue Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants