Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run script loads training dataset #67

Closed
jindrahelcl opened this issue Jul 13, 2016 · 13 comments
Closed

Run script loads training dataset #67

jindrahelcl opened this issue Jul 13, 2016 · 13 comments
Assignees
Labels

Comments

@jindrahelcl
Copy link
Member

Runner should not load the training dataset again.

@jlibovicky
Copy link
Contributor

Where is this happening?

@jindrahelcl
Copy link
Member Author

jindrahelcl commented Jul 13, 2016

I am trying to run this now, maybe I've got it wrong. I've run the training from commit cc1ec7d. I use the same ini script that I used for training (see attachment qtleap-alpha.ini), and I use the val_dataset.ini as the dataset config.

It seems the dataset arguments are not ignored.

I am also getting errors probably caused by the dataset init helper:

Error while loading 'val_data': '_sre.SRE_Match' object is not subscriptable
(...)
File "/home/jihe01/mmmt/bin/neuralmonkey/config/utils.py", line 46, in <dictcomp>
    if SERIES_OUTPUT.match(key)}

val_datasets.ini.txt
qtleap-alpha.ini.txt

NOTE the out_...out is just a thing I tried.. before this change there was the same error with s..._out keys..

@jindrahelcl
Copy link
Member Author

It seems I've figured out the error. There was a leftover Python 2 matching of the regex.

@jlibovicky
Copy link
Contributor

Is this solved?

@jindrahelcl
Copy link
Member Author

It shoudl be solved in the experiment object branch. (#73) (berliner refactor)

@obo obo added this to the WMT17 Tuning Task milestone Nov 10, 2016
@jlibovicky
Copy link
Contributor

I don't think it happens any more, though I don't when it got fixed.

@jindrahelcl
Copy link
Member Author

jindrahelcl commented Nov 30, 2016 via email

@jlibovicky
Copy link
Contributor

jlibovicky commented Dec 20, 2016

According to the tests cases logs it does not happen any more.

@jindrahelcl
Copy link
Member Author

:D :D cože? :-)

@jlibovicky
Copy link
Contributor

:-D už je to dobře

@jindrahelcl
Copy link
Member Author

škoda.. :-)

@kocmitom
Copy link
Contributor

Isn't it somehow connected with #210 ?

@jlibovicky
Copy link
Contributor

Not at all. This was about handling configuration in run.py script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants