fix issue #782 #783
Merged
fix issue #782 #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlibovicky
requested changes
Jan 2, 2019
neuralmonkey/tests/test_chrf.py
Outdated
| from neuralmonkey.evaluators.chrf import ChrFEvaluator | ||
|
|
||
|
|
||
| CORPUS_DECODED = [ |
There was a problem hiding this comment.
Neni lepší to naimportovat z testu na BLEU?
There was a problem hiding this comment.
Jasne, to asi jo. Nebo respektive to mit uplne bokem; porovnavani s hypo vet s refe vetama delas u vice metrik
neuralmonkey/evaluators/chrf.py
Outdated
| ngr_dicts = [] | ||
| for m in range(1, n + 1): | ||
| ngr_dict = {} # type: Dict[str, int] | ||
| for i in range(m, len(tokens)): | ||
| # if m > len(tokens), return an empty dict |
jindrahelcl
approved these changes
Jan 2, 2019
jlibovicky
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #782 showed that there were some problems with edge cases (empty sentences, etc.). This PR solves these issues
test_chrf.py is also included to automatically test desired behaviour