Closes issue #205, issue #210, issue #211, and issue #212: Added 'U.S… #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. veteran role'; added 'lives in'; add classes for social categories and identities; and added 'occupation disposition' and 'occupation activity'.
|
The occupation class definitions for issue #212 both refer to occupation role but we decided to not have that class and use job role instead, I thought? I wonder if we should change the language to say 'job role' |
|
I can change the definition to say "job role." |
|
Ok do that and it’s good to go
…On Thu, Sep 14, 2023 at 2:22 PM Matthew Diller ***@***.***> wrote:
I can change the definition to say "job role."
—
Reply to this email directly, view it on GitHub
<#213 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJR55RLLSQNVT6FKNHQDUDX2NKN7ANCNFSM6AAAAAA4SQVMZE>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
…n activity' and 'occupation disposition'.
|
Done. Will publish a new release after lunch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…. veteran role'; added 'lives in'; add classes for social categories and identities; and added 'occupation disposition' and 'occupation activity'.