Add version number to iOS and Mac clients and bump it to 2.1.6

Also send the sdk name and version number as part of the request if HockeyApp is used as a server
uffdalu · Mar 8, 2012 · 54c23b2 · 54c23b2
1 parent cc626c1
commit 54c23b2
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 11 deletions.
diff --git a/client/Mac/BWQuincyManager.m b/client/Mac/BWQuincyManager.m
@@ -31,6 +31,9 @@
 #import "BWQuincyUI.h"
 #import <sys/sysctl.h>
 
+#define SDK_NAME @"Quincy"
+#define SDK_VERSION @"2.1.6"
+
 @interface BWQuincyManager(private)
 - (void) startManager;
 
@@ -295,11 +298,14 @@ - (void)_postXML:(NSString*)xml toURL:(NSURL*)url {
   NSString *boundary = @"----FOO";
 
   if (self.appIdentifier) {
-    request = [NSMutableURLRequest requestWithURL:[NSURL URLWithString:[NSString stringWithFormat:@"%@api/2/apps/%@/crashes",
-                                                                        self.submissionURL,
-                                                                        [self.appIdentifier stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
-                                                                        ]
-                                                   ]];
+    request = [NSMutableURLRequest requestWithURL:
+               [NSURL URLWithString:[NSString stringWithFormat:@"%@api/2/apps/%@/crashes?sdk=%@&sdk_version=%@",
+                                     self.submissionURL,
+                                     [self.appIdentifier stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding],
+                                     SDK_NAME,
+                                     SDK_VERSION
+                                     ]
+                ]];
   } else {
     request = [NSMutableURLRequest requestWithURL:url];
   }

diff --git a/client/iOS/BWQuincyManager.m b/client/iOS/BWQuincyManager.m
@@ -35,6 +35,9 @@
 #include <sys/sysctl.h>
 #include <inttypes.h> //needed for PRIx64 macro
 
+#define SDK_NAME @"Quincy"
+#define SDK_VERSION @"2.1.6"
+
 NSBundle *quincyBundle(void) {
   static NSBundle* bundle = nil;
   if (!bundle) {
@@ -606,11 +609,13 @@ - (void)_postXML:(NSString*)xml toURL:(NSURL*)url {
 
   if (self.appIdentifier) {
     request = [NSMutableURLRequest requestWithURL:
-      [NSURL URLWithString:[NSString stringWithFormat:@"%@api/2/apps/%@/crashes",
-                            self.submissionURL,
-                            [self.appIdentifier stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]
-                            ]
-       ]];
+               [NSURL URLWithString:[NSString stringWithFormat:@"%@api/2/apps/%@/crashes?sdk=%@&sdk_version=%@",
+                                     self.submissionURL,
+                                     [self.appIdentifier stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding],
+                                     SDK_NAME,
+                                     SDK_VERSION
+                                     ]
+                ]];
   } else {
     request = [NSMutableURLRequest requestWithURL:url];
   }

diff --git a/demo/iOS/QuincyDemo.xcodeproj/project.pbxproj b/demo/iOS/QuincyDemo.xcodeproj/project.pbxproj
@@ -164,7 +164,7 @@
 		29B97313FDCFA39411CA2CEA /* Project object */ = {
 			isa = PBXProject;
 			attributes = {
-				LastUpgradeCheck = 0420;
+				LastUpgradeCheck = 0430;
 			};
 			buildConfigurationList = C01FCF4E08A954540054247B /* Build configuration list for PBXProject "QuincyDemo" */;
 			compatibilityVersion = "Xcode 3.2";