passing nc back from microphysics #109
Conversation
AnningCheng-NOAA
requested review from
gthompsnWRF,
RuiyuSun,
grantfirl,
Qingfu-Liu and
dustinswales
as code owners
grantfirl
dismissed
gthompsnWRF’s stale review
Comment was addressed by @AnningCheng-NOAA
|
@grantfirl can you help @AnningCheng-NOAA to sync up the branch? |
Sure. |
|
@jkbk2004 @AnningCheng-NOAA This branch is synced to the latest ufs/dev. Anning, it looks like you synced to the NCAR/main branch instead of the ufs-community/ufs/dev branch, but I've fixed it. If you make sure that I'm a collaborator (how to do this) on your branches of fv3atm and ufs-weather-model, I'll sync those up too. My GitHub username is @grantfirl |
|
@grantfirl you are added |
|
@AnningCheng-NOAA I know that I am a collaborator for your ccpp-physics fork, but I need to be a collaborator on your fv3atm and ufs-weather-model forks to be able to push commits to them. |
|
Grant:
You can be found in the two repos
…On Thu, Oct 12, 2023 at 5:38 PM Grant Firl ***@***.***> wrote:
@AnningCheng-NOAA <https://github.com/AnningCheng-NOAA> I know that I am
a collaborator for your ccpp-physics fork, but I need to be a collaborator
on your fv3atm and ufs-weather-model forks to be able to push commits to
them.
—
Reply to this email directly, view it on GitHub
<#109 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQPMIIDM4PSW75F6HUUWDLX7BPHDANCNFSM6AAAAAA5DFQ3VE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@grantfirl , we are finished with testing on ufs-wm PR #1915 . Please feel free to merge this ccpp-physics PR when you're able. |
passing nc back from microphysics is the main reason for the bug fixing, pass nifa and nwfa back is more or less for diagnostic purpose