Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed instability in upper atmosphere due to OGWD #111

Merged
merged 9 commits into from
Oct 23, 2023

Conversation

mdtoyNOAA
Copy link
Collaborator

@mdtoyNOAA mdtoyNOAA commented Sep 26, 2023

This PR fixes Issue #95, which involved a stability issue in the upper atmosphere due to the orographic gravity wave drag (OGWD) scheme and also limits the surface OGWD stress in regions of high surface winds (and/or low near-surface static stability) in which internal gravity waves should not develop.

…er for orographic gravity wave drag in UGWP -- Issue NOAA-GSL#95
@mdtoyNOAA mdtoyNOAA marked this pull request as ready for review September 27, 2023 18:03
Copy link
Collaborator

@dustinswales dustinswales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdtoyNOAA The changes look good to me. Thanks!

@jkbk2004
Copy link

@mdtoyNOAA can you combine in code change from #115 to this PR?

@mdtoyNOAA
Copy link
Collaborator Author

@mdtoyNOAA can you combine in code change from #115 to this PR?

@jkbk2004 Sure I can do that. Just to make sure, would I pull Helin's 'hr3_land_upgrades' branch from the fork https://github.com/HelinWei-NOAA/ccpp-physics/tree/hr3_land_upgrades into my branch? Also, would I need to run RT's right away, or can I wait until Monday, 10/16 when it's my turn to merge the ufs-weather-model PR#1923?

@barlage
Copy link
Collaborator

barlage commented Oct 17, 2023

@mdtoyNOAA can you merge the hr3_land_upgrades branch again? @HelinWei-NOAA just pushed a final commit to that branch.

@mdtoyNOAA
Copy link
Collaborator Author

@mdtoyNOAA can you merge the hr3_land_upgrades branch again? @HelinWei-NOAA just pushed a final commit to that branch.

@barlage Yes, I can do that, but first I'd like to confirm that I should not merge Anning's PR#109 before doing that. Or does it matter?

@mdtoyNOAA
Copy link
Collaborator Author

@barlage I merged the new hr3_land_upgrades branch.

@zach1221
Copy link

@grantfirl testing is complete on ufs-wm PR #1923, can you merge this PR for us, please?

@grantfirl grantfirl merged commit 1db5691 into ufs-community:ufs/dev Oct 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
8 participants