Add explicit alpha_fd coefficient to TOFD in drag_suite.F90 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 28, 2024
grantfirl
reviewed
May 29, 2024
| [alpha_fd] | ||
| standard_name = alpha_coefficient_for_turbulent_orographic_form_drag | ||
| long_name = alpha coefficient for Beljaars et al turbulent orographic form drag | ||
| units = none |
There was a problem hiding this comment.
Minor: units should be 1 here. See https://github.com/ESCOMP/CCPPStandardNames/blob/main/StandardNamesRules.rst.
Please make the same change everywhere else this variable is used in ccpp/physics and fv3atm.
grantfirl
reviewed
May 29, 2024
Thank you. @grantfirl This draft PR is being folded in to PR #207, but I see you've made the same comment in that thread, so all should be well. |
dustinswales
approved these changes
May 30, 2024
|
This is to be combined into #207 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added explicit 'alpha_fd' coefficient to drag_suite.F90 which corresponds directly to 'alpha' coefficient in Beljaars et al. (QJRMS, 2004), which by default is 12.0. The coefficient will be a runtime namelist option, and can control the strength of the turbulent orographic form drag (TOFD).
Note that the runtime results are bit-for-bit identical to those of the previous version unless a value other than alpha_fd = 12.0 in the namelist.
Regression tests have been performed on Hera with the Intel and Gnu compilers. The tests involving ugwpv1 all passed for both intel and gnu compilers, however, some of the other gnu tests failed. These tests also failed with the previous commit, so failures don't appear to have to do with the code changes in this PR.
Issues
This PR addresses ccpp-physics Issue #208.