Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/alt compsetrun #75

Merged
merged 15 commits into from
May 1, 2020
Merged

Feature/alt compsetrun #75

merged 15 commits into from
May 1, 2020

Conversation

MinsukJi-NOAA
Copy link
Collaborator

Issue #74

  • Regression tests using shell scripts (rt.sh and others) were implemented
  • 2 ipd prod & 12 ccpp prod cases were added and tested on Hera

@MinsukJi-NOAA
first commit: tests/rt.sh works for cpld_fv3_mom6_cice_cold_atm_flux
9a02c8f
@MinsukJi-NOAA
Merge remote-tracking branch 'upstream/develop' into feature/alt_comp…
7d04241 
…setrun
@MinsukJi-NOAA
Update submodules to match latest s2s develop's
34f1c36
@MinsukJi-NOAA
Add CPLWAV2ATM to default_vars. Change baseline to develop-20200326
d8eeddd
@MinsukJi-NOAA
Add test case: cpld_fv3_mom6_cice_2d_atm_flux
453dd17
@MinsukJi-NOAA
Add case cpld_fv3_ccpp_mom6_cice_cold_atm_flux. Modify rt.sh for crea…
84fdd10 
…te_baseline
@MinsukJi-NOAA
Modify rt.sh and rt_utils.sh to make 'create baseline' work
a14a758
@MinsukJi-NOAA
Added all CCPP PROD tests, Orion changes
9642ea5
@MinsukJi-NOAA
Complete CCPP PRO unit tests on Hera
cae0c42 
*Consolidated fv3_conf/*_run.IN files
*Modified tests/default_vars.sh and tests/TEST_NAME files
*RegressionTests_hera shows passing of all tests
@MinsukJi-NOAA
Add Orion-related config & module file
982758a
@MinsukJi-NOAA
Make Rocoto workflow manager work for S2S model
89abc20
@MinsukJi-NOAA
Make ecflow workflow manager work for S2S model
d6b645e
@MinsukJi-NOAA
Modifications for Orion
a9b86eb
DeniseWorthen
DeniseWorthen reviewed May 1, 2020
View reviewed changes
conf/configure.fv3.orion.intel

FFLAGS_OPT = -O2 -debug minimal -fp-model source -qoverride-limits -qopt-prefetch=3
FFLAGS_REPRO = -O2 -debug minimal -fp-model consistent -qoverride-limits -g -traceback
FFLAGS_DEBUG = -g -O0 -check all -check noarg_temp_created -check nopointer -warn -warn noerrors -fp-stack-check -fstack-protector-all -fpe0 -debug -traceback -ftrapuv
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like at commit a59b6cf we lost the additional debug flag -link_mpi=dbg in the hera.intel configuration; that has now propagated forward to the orion configuration.

Since adding this back might cause the debug test to fail, I will create an issue for adding this setting back to both the hera.intel and orion.intel.

@DeniseWorthen
Copy link
Collaborator

Just to confirm my understanding, you were able to pass all 14 CCPP PROD baselines on Hera using rt.sh, correct?

@MinsukJi-NOAA
Copy link
Collaborator Author

Just to confirm my understanding, you were able to pass all 14 CCPP PROD baselines on Hera using rt.sh, correct?

Yes. The results can be found in tests/RegressionTests_hera.intel.log.

@DeniseWorthen
Copy link
Collaborator

Sorry, I should have been more clear. The baselines were created using the NEMSCompsetRun; you were able to pass all those baselines using rt.sh.

@MinsukJi-NOAA
Copy link
Collaborator Author

Sorry, I should have been more clear. The baselines were created using the NEMSCompsetRun; you were able to pass all those baselines using rt.sh.

Yes. Baselines were created using NEMSCompsetRun.

Actually 2 are IPD PROD cases. 12 CCPP PROD cases do not include Debug and Gfdlmprad_*

DeniseWorthen
DeniseWorthen approved these changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the rt.sh tests pass the NemsCompsetRun baselines, I think this good to go.

@MinsukJi-NOAA
Copy link
Collaborator Author

@DeniseWorthen, I need to update this branch to the latest develop, right? I will do that, run rt.sh again on Hera, and report the results.

@DeniseWorthen
Copy link
Collaborator

Yes, I think that is my understanding. Then we will have a second commit on s2s for updating the components to their Orion ports.

@junwang-noaa
Copy link
Collaborator

junwang-noaa commented May 1, 2020 via email

@MinsukJi-NOAA
Copy link
Collaborator Author

@DeniseWorthen DeniseWorthen merged commit 63b1aab into ufs-community:develop May 1, 2020
DeniseWorthen added a commit to DeniseWorthen/ufs-s2s-model that referenced this pull request May 4, 2020
@DeniseWorthen
Merge pull request #25 from ufs-community/develop
5381fc4 
Feature/alt compsetrun (ufs-community#75)
@MinsukJi-NOAA MinsukJi-NOAA deleted the feature/alt_compsetrun branch May 6, 2020 20:28
@MinsukJi-NOAA MinsukJi-NOAA mentioned this pull request May 7, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junwang-noaa junwang-noaa junwang-noaa approved these changes

@DeniseWorthen DeniseWorthen DeniseWorthen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MinsukJi-NOAA @DeniseWorthen @junwang-noaa