Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Fix sample script and WE2E test for AQM #1040

Merged
merged 9 commits into from
Mar 5, 2024

Conversation

chan-hoo
Copy link
Collaborator

@chan-hoo chan-hoo commented Feb 19, 2024

DESCRIPTION OF CHANGES:

  • Fixes the failure on the sample script ush/config.aqm.community.yaml.
  • Fixes the failure on the WE2E test test/WE2E/test_configs/aqm/config.aqm_grid_AQM_NA13km_suite_GFS_v16.yaml for AQM.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • Sample script run: config.aqm.community.yaml

  • WE2E test: config.aqm_grid_AQWM_NA13km_suite_GFS_v16.yaml

  • hera.intel

  • orion.intel

  • hercules.intel

  • cheyenne.intel

  • cheyenne.gnu

  • derecho.intel

  • gaea.intel

  • gaeac5.intel

  • jet.intel

  • wcoss2.intel

  • NOAA Cloud (indicate which platform)

  • Jenkins

  • fundamental test suite

  • comprehensive tests (specify which if a subset was used)

ISSUE:

Fixes issue mentioned in #1019

CHECKLIST

  • My code follows the style guidelines in the Contributor's Guide
  • I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes do not require updates to the documentation (explain).
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

CONTRIBUTORS:

@MichaelLueken @RatkoVasic-NOAA

@MichaelLueken
Copy link
Collaborator

@chan-hoo, Thank you very much for running the updated config.aqm.community.yaml sample script and config.aqm_grid_AQWM_NA13km_suite_GFS_v16.yaml WE2E test!

Please run the fundamental test suite on one of the machines as well, to ensure that these changes don't adversely affect the fundamental test suite.

In the tests/WE2E directory, using:

./run_WE2E_tests.py -t fundamental -m <machine> -a <account>

will allow you to run the fundamental test suite on a given machine. Since you are still onboarding to EPIC, please let me know and I can run the fundamental test suite on a machine for you.

Thanks

@chan-hoo
Copy link
Collaborator Author

@MichaelLueken, the fundamental test has been completed successfully on Hera:

All 7 experiments finished
Calculating core-hour usage and printing final summary
----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE               8.80
nco_grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_timeoffset_suite_  COMPLETE              11.89
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240  COMPLETE               6.99
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              13.70
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024022  COMPLETE              26.67
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240220160  COMPLETE              13.61
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024022016095  COMPLETE              19.35
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             101.01

@MichaelLueken
Copy link
Collaborator

@chan-hoo, thank you very much for running the fundamental tests on Hera! Once my AQM testing is complete, I will provide an approval for this work.

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chan-hoo, my AQM WE2E test has finally finished on Hera and the test has successfully passed. These changes are similar to the changes that I have applied to update the test to the new 202311100000 - 202311110000 dates for the WE2E test.

Everything looks good, approving now!

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20240220144109                   COMPLETE            2686.93
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE            2686.93

Copy link
Collaborator

@RatkoVasic-NOAA RatkoVasic-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Hera:

----------------------------------------------------------------------------------------------------
Experiment name                                                  | Status    | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2  COMPLETE               8.84
nco_grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_timeoffset_suite_  COMPLETE              12.47
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240  COMPLETE               7.48
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot  COMPLETE              12.73
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024022  COMPLETE              26.66
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240228171  COMPLETE              13.53
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024022817165  COMPLETE              19.42
----------------------------------------------------------------------------------------------------
Total                                                              COMPLETE             101.13

Detailed summary written to /scratch2/NCEPDEV/fv3-cam/Ratko.Vasic/1040/expt_dirs/WE2E_summary_20240228190343.txt

Approved.

@chan-hoo
Copy link
Collaborator Author

@RatkoVasic-NOAA, thank you very much for reviewing this PR!!! :)

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Feb 29, 2024
@MichaelLueken
Copy link
Collaborator

The Jenkins tests have passed for Derecho, Hercules, Jet, and Orion. There were issues for both Hera Intel and Hera GNU. A rerun on Hera allowed the Hera Intel tests to pass, but the get_from_NOMADS_ics_FV3GFS_lbcs_FV3GFS test failed in Hera GNU. Attempting to rerun the one failed test now.

Once it passes, I will merge this PR.

@MichaelLueken MichaelLueken merged commit d4043ce into ufs-community:develop Mar 5, 2024
3 of 5 checks passed
@chan-hoo chan-hoo deleted the bugfix/aqm_sample branch March 28, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SRW-AQM] AQM sample script 'config.aqm.community.yaml' fails due to missing data files
3 participants