-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[develop] Fix sample script and WE2E test for AQM #1040
[develop] Fix sample script and WE2E test for AQM #1040
Conversation
… into bugfix/aqm_sample
@chan-hoo, Thank you very much for running the updated Please run the fundamental test suite on one of the machines as well, to ensure that these changes don't adversely affect the fundamental test suite. In the
will allow you to run the fundamental test suite on a given machine. Since you are still onboarding to EPIC, please let me know and I can run the fundamental test suite on a machine for you. Thanks |
@MichaelLueken, the fundamental test has been completed successfully on Hera:
|
@chan-hoo, thank you very much for running the fundamental tests on Hera! Once my AQM testing is complete, I will provide an approval for this work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chan-hoo, my AQM WE2E test has finally finished on Hera and the test has successfully passed. These changes are similar to the changes that I have applied to update the test to the new 202311100000 - 202311110000 dates for the WE2E test.
Everything looks good, approving now!
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
aqm_grid_AQM_NA13km_suite_GFS_v16_20240220144109 COMPLETE 2686.93
----------------------------------------------------------------------------------------------------
Total COMPLETE 2686.93
… into bugfix/aqm_sample
… into bugfix/aqm_sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Hera:
----------------------------------------------------------------------------------------------------
Experiment name | Status | Core hours used
----------------------------------------------------------------------------------------------------
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_RAP_suite_RRFS_v1beta_2 COMPLETE 8.84
nco_grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_timeoffset_suite_ COMPLETE 12.47
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v15p2_20240 COMPLETE 7.48
grid_RRFS_CONUS_25km_ics_FV3GFS_lbcs_FV3GFS_suite_GFS_v17_p8_plot COMPLETE 12.73
grid_RRFS_CONUScompact_25km_ics_HRRR_lbcs_HRRR_suite_HRRR_2024022 COMPLETE 26.66
grid_SUBCONUS_Ind_3km_ics_HRRR_lbcs_RAP_suite_WoFS_v0_20240228171 COMPLETE 13.53
grid_RRFS_CONUS_25km_ics_NAM_lbcs_NAM_suite_GFS_v16_2024022817165 COMPLETE 19.42
----------------------------------------------------------------------------------------------------
Total COMPLETE 101.13
Detailed summary written to /scratch2/NCEPDEV/fv3-cam/Ratko.Vasic/1040/expt_dirs/WE2E_summary_20240228190343.txt
Approved.
@RatkoVasic-NOAA, thank you very much for reviewing this PR!!! :) |
The Jenkins tests have passed for Derecho, Hercules, Jet, and Orion. There were issues for both Hera Intel and Hera GNU. A rerun on Hera allowed the Hera Intel tests to pass, but the Once it passes, I will merge this PR. |
DESCRIPTION OF CHANGES:
ush/config.aqm.community.yaml
.test/WE2E/test_configs/aqm/config.aqm_grid_AQM_NA13km_suite_GFS_v16.yaml
for AQM.Type of change
TESTS CONDUCTED:
Sample script run:
config.aqm.community.yaml
WE2E test:
config.aqm_grid_AQWM_NA13km_suite_GFS_v16.yaml
hera.intel
orion.intel
hercules.intel
cheyenne.intel
cheyenne.gnu
derecho.intel
gaea.intel
gaeac5.intel
jet.intel
wcoss2.intel
NOAA Cloud (indicate which platform)
Jenkins
fundamental test suite
comprehensive tests (specify which if a subset was used)
ISSUE:
Fixes issue mentioned in #1019
CHECKLIST
CONTRIBUTORS:
@MichaelLueken @RatkoVasic-NOAA