Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update miniconda3/4.12.0 module and regional_workflow environment on Cheyenne, Hera, Jet, Orion #431

Closed
wants to merge 35 commits into from
Closed

Update miniconda3/4.12.0 module and regional_workflow environment on Cheyenne, Hera, Jet, Orion #431

Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
790f87d
Update build_cheyenne_gnu.lua
natalie-perlin Oct 25, 2022
eb1ceca
Update build_cheyenne_intel.lua
natalie-perlin Oct 25, 2022
2ccdc92
Update wflow_cheyenne.lua
natalie-perlin Oct 25, 2022
5c7282c
Update wflow_hera.lua
natalie-perlin Oct 25, 2022
01ed3ba
Update wflow_jet.lua
natalie-perlin Oct 25, 2022
3e535f1
Update wflow_orion.lua
natalie-perlin Oct 25, 2022
c1d3ed6
Update load_modules_run_task.sh
natalie-perlin Oct 25, 2022
ac4a2dd
Update wflow_cheyenne.lua
natalie-perlin Oct 25, 2022
9e47ee6
Update and rename conda_regional_workflow.lua to miniconda_regional_w…
natalie-perlin Oct 25, 2022
8b1aa08
Update make_grid.local.lua
natalie-perlin Oct 25, 2022
d94c44c
Update get_extrn_ics.local.lua
natalie-perlin Oct 25, 2022
67fe20e
Update get_extrn_lbcs.local.lua
natalie-perlin Oct 25, 2022
5e62ff5
Update make_ics.local.lua
natalie-perlin Oct 25, 2022
ada2e20
Update make_lbcs.local.lua
natalie-perlin Oct 25, 2022
7394e9f
Update and rename make_orog.hardcoded.lua to make_orog.local.lua
natalie-perlin Oct 25, 2022
846e01b
Update run_fcst.local.lua
natalie-perlin Oct 25, 2022
4c94608
Update run_vx.local.lua
natalie-perlin Oct 25, 2022
0e1b216
Create make_sfc_climo.local.lua
natalie-perlin Oct 25, 2022
4615ab9
Update miniconda_regional_workflow.lua
natalie-perlin Oct 25, 2022
05eb788
Update get_obs.local.lua
natalie-perlin Oct 25, 2022
776de68
Update miniconda_regional_workflow.lua
natalie-perlin Oct 25, 2022
835d841
Update miniconda_regional_workflow.lua
natalie-perlin Oct 25, 2022
feb66bb
Update build_cheyenne_gnu.lua
natalie-perlin Oct 27, 2022
4d56e78
Update build_cheyenne_intel.lua
natalie-perlin Oct 27, 2022
9febdcb
Update build_gaea_intel.lua
natalie-perlin Oct 27, 2022
542f6b7
Update build_hera_intel.lua
natalie-perlin Oct 27, 2022
d15f89f
Update build_jet_intel.lua
natalie-perlin Oct 27, 2022
7545fb9
Update build_orion_intel.lua
natalie-perlin Oct 27, 2022
07288d6
Merge branch 'ufs-community:develop' into develop_miniconda3_update
natalie-perlin Oct 27, 2022
74b8420
Update load_modules_wflow.sh
natalie-perlin Oct 27, 2022
a974451
Update miniconda_regional_workflow.lua
natalie-perlin Oct 27, 2022
65c3704
Update miniconda_regional_workflow.lua
natalie-perlin Oct 27, 2022
4ea989a
Update miniconda_regional_workflow.lua
natalie-perlin Oct 27, 2022
1a3f26b
Update miniconda_regional_workflow.lua
natalie-perlin Oct 27, 2022
13ac404
Update miniconda_regional_workflow.lua
natalie-perlin Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion modulefiles/build_cheyenne_gnu.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ the CISL machine Cheyenne using GNU
whatis([===[Loads libraries needed for building the UFS SRW App on Cheyenne ]===])

load(pathJoin("cmake", os.getenv("cmake_ver") or "3.22.0"))
load(pathJoin("python", os.getenv("python_ver") or "3.7.9"))
load(pathJoin("ncarenv", os.getenv("ncarenv_ver") or "1.3"))
load(pathJoin("gnu", os.getenv("gnu_ver") or "11.2.0"))
load(pathJoin("mpt", os.getenv("mpt_ver") or "2.25"))
Expand Down
1 change: 0 additions & 1 deletion modulefiles/build_cheyenne_intel.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ the CISL machine Cheyenne using Intel-2022.1
whatis([===[Loads libraries needed for building the UFS SRW App on Cheyenne ]===])

load(pathJoin("cmake", os.getenv("cmake_ver") or "3.22.0"))
load(pathJoin("python", os.getenv("python_ver") or "3.7.9"))
load(pathJoin("ncarenv", os.getenv("ncarenv_ver") or "1.3"))
load(pathJoin("intel", os.getenv("intel_ver") or "2022.1"))
load(pathJoin("mpt", os.getenv("mpt_ver") or "2.25"))
Expand Down
3 changes: 0 additions & 3 deletions modulefiles/tasks/cheyenne/conda_regional_workflow.lua
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion modulefiles/tasks/cheyenne/get_extrn_ics.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
load("conda_regional_workflow")
load("miniconda_regional_workflow")
2 changes: 1 addition & 1 deletion modulefiles/tasks/cheyenne/get_extrn_lbcs.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
load("conda_regional_workflow")
load("miniconda_regional_workflow")
2 changes: 1 addition & 1 deletion modulefiles/tasks/cheyenne/make_grid.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
load("conda_regional_workflow")
load("miniconda_regional_workflow")
2 changes: 1 addition & 1 deletion modulefiles/tasks/cheyenne/make_ics.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
load("conda_regional_workflow")
load("miniconda_regional_workflow")
2 changes: 1 addition & 1 deletion modulefiles/tasks/cheyenne/make_lbcs.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
load("conda_regional_workflow")
load("miniconda_regional_workflow")
4 changes: 0 additions & 4 deletions modulefiles/tasks/cheyenne/make_orog.hardcoded.lua
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions modulefiles/tasks/cheyenne/make_orog.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
load("miniconda_regional_workflow")
2 changes: 2 additions & 0 deletions modulefiles/tasks/cheyenne/make_sfc_climo.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

load("miniconda_regional_workflow")
3 changes: 3 additions & 0 deletions modulefiles/tasks/cheyenne/miniconda_regional_workflow.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
prepend_path("MODULEPATH","/glade/work/epicufsrt/contrib/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))
setenv("SRW_ENV", "regional_workflow")
2 changes: 1 addition & 1 deletion modulefiles/tasks/cheyenne/run_fcst.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
load("conda_regional_workflow")
load("miniconda_regional_workflow")
2 changes: 1 addition & 1 deletion modulefiles/tasks/cheyenne/run_vx.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
load("conda_regional_workflow")
load("miniconda_regional_workflow")
5 changes: 1 addition & 4 deletions modulefiles/tasks/hera/get_obs.local.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
load("hpss")
prepend_path("MODULEPATH", "/contrib/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.5.12")

setenv("SRW_ENV", "pygraf")
load("miniconda_regional_workflow")
4 changes: 2 additions & 2 deletions modulefiles/tasks/hera/miniconda_regional_workflow.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
prepend_path("MODULEPATH", "/contrib/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.5.12"))
prepend_path("MODULEPATH", "/scratch1/NCEPDEV/nems/role.epic/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))

setenv("SRW_ENV", "regional_workflow")
2 changes: 1 addition & 1 deletion modulefiles/tasks/jet/miniconda_regional_workflow.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
prepend_path("MODULEPATH", "/contrib/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.5.12"))
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))

setenv("SRW_ENV", "regional_workflow")
4 changes: 2 additions & 2 deletions modulefiles/tasks/orion/miniconda_regional_workflow.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
append_path("MODULEPATH", "/apps/contrib/miniconda3-noaa-gsl/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "3.8"))
append_path("MODULEPATH", "/work/noaa/epic-ps/role-epic-ps/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))

setenv("SRW_ENV", "regional_workflow")
5 changes: 3 additions & 2 deletions modulefiles/wflow_cheyenne.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,12 @@ load("ncarenv")
append_path("MODULEPATH","/glade/p/ral/jntp/UFS_SRW_app/modules")
load("rocoto")

load(pathJoin("conda", os.getenv("conda_ver") or "latest"))
prepend_path("MODULEPATH","/glade/work/epicufsrt/contrib/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))

if mode() == "load" then
LmodMsgRaw([===[Please do the following to activate conda:
> conda activate /glade/p/ral/jntp/UFS_SRW_app/conda/regional_workflow
> conda activate regional_workflow
Comment on lines 17 to +18
Copy link
Collaborator

@danielabdi-noaa danielabdi-noaa Oct 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see Cheyenne is similar to other systems in this regard now! I think you would need to do the same in ush/load_modules_wflow.sh lines 63-69

-if [[ "${machine}" == 'cheyenne' ]]; then
-    conda activate /glade/p/ral/jntp/UFS_SRW_app/conda/regional_workflow
-else
-    if [ ! -z $(command -v conda) ]; then
-        conda activate regional_workflow
-    fi
+if [ ! -z $(command -v conda) ]; then
+    conda activate regional_workflow
 fi

]===])
end

4 changes: 2 additions & 2 deletions modulefiles/wflow_hera.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ whatis([===[Loads libraries needed for running the UFS SRW App on Hera ]===])

load("rocoto")

prepend_path("MODULEPATH","/contrib/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.5.12"))
prepend_path("MODULEPATH","/scratch1/NCEPDEV/nems/role.epic/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))

if mode() == "load" then
LmodMsgRaw([===[Please do the following to activate conda:
Expand Down
4 changes: 2 additions & 2 deletions modulefiles/wflow_jet.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ whatis([===[Loads libraries needed for running the UFS SRW App on Jet ]===])

load("rocoto")

prepend_path("MODULEPATH","/contrib/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.5.12"))
prepend_path("MODULEPATH","/mnt/lfs4/HFIP/hfv3gfs/role.epic/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))

if mode() == "load" then
LmodMsgRaw([===[Please do the following to activate conda:
Expand Down
4 changes: 2 additions & 2 deletions modulefiles/wflow_orion.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ whatis([===[Loads libraries needed for running SRW on Orion ]===])
load("contrib")
load("rocoto")

append_path("MODULEPATH","/apps/contrib/miniconda3-noaa-gsl/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "3.8"))
append_path("MODULEPATH","/work/noaa/epic-ps/role-epic-ps/miniconda3/modulefiles")
load(pathJoin("miniconda3", os.getenv("miniconda3_ver") or "4.12.0"))

if mode() == "load" then
LmodMsgRaw([===[Please do the following to activate conda:
Expand Down
4 changes: 2 additions & 2 deletions ush/load_modules_run_task.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,10 @@ module list
if [ -n "${SRW_ENV:-}" ] ; then
set +u
conda activate ${SRW_ENV}
if [ $machine = "gaea" ]; then
# if [ $machine = "gaea" ]; then
conda deactivate
conda activate ${SRW_ENV}
fi
# fi
Comment on lines 186 to +190
Copy link
Collaborator

@danielabdi-noaa danielabdi-noaa Oct 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like now you had to do the deactivate->activate process for all systems now -- we were hoping for the opposite with your PR! I guess it must be the transition from TCL to Lua of miniconda3 file epic installations that is causing this. Did you have to do this with your previous PR?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@natalie-perlin Looking at PR #419, I didn't see this modification. Is this required due to only using the new miniconda3 modules? @mark-a-potts has opened PR #428 to remove this logic, along with the conda deactivate and conda activate ${SRW_ENV}. It would be best to remove this, rather than make all machines require it. Would you be able to run tests of removing this logic and making similar changes that @mark-a-potts made for the Gaea local modulefiles in PR #428?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielabdi-noaa - this fix was temporary that we found would work on all systems. It is likely related to additional loads of miniconda3 in *.local.lua files if/when they are used. This module loading changes the binaries search $PATH once again. The use of *local.lua files may still need revisiting, checking the options now (@mark-a-potts does testing as well)

set -u
fi

Expand Down