Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[develop] Adding SPFH to Metplus config file #552

Merged
merged 3 commits into from
Jan 20, 2023

Conversation

panll
Copy link
Collaborator

@panll panll commented Jan 20, 2023

DESCRIPTION OF CHANGES:

Adding specific humidity (SPFH) to Metplus config file for verification.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

TESTS CONDUCTED:

  • [ x] hera.intel
  • orion.intel
  • cheyenne.intel
  • cheyenne.gnu
  • gaea.intel
  • jet.intel
  • wcoss2.intel
  • NOAA Cloud (indicate which platform)
  • Jenkins
  • fundamental test suite
  • comprehensive tests (specify which if a subset was used)

DEPENDENCIES:

None

DOCUMENTATION:

N/A

ISSUE:

N/A

CHECKLIST

  • [ x] My code follows the style guidelines in the Contributor's Guide
  • [ x] I have performed a self-review of my own code using the Code Reviewer's Guide
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • [x ] My changes do not require updates to the documentation (explain).
    The change only relate to METPLUS configuration file.
  • My changes generate no new warnings
  • [x ] New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Collaborator

@JeffBeck-NOAA JeffBeck-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @linlin-pan, thanks for adding specific humidity to the verification! I only see 2-m SPFH at the moment, though.

@MichaelLueken MichaelLueken changed the title Adding SPFH to Metplus config file [develop] Adding SPFH to Metplus config file Jan 20, 2023
@panll
Copy link
Collaborator Author

panll commented Jan 20, 2023

Hi @linlin-pan, thanks for adding specific humidity to the verification! I only see 2-m SPFH at the moment, though.

The upper air part is already included in file PointStat_upper_air.conf. Thanks @JeffBeck-NOAA !

Copy link
Collaborator

@MichaelLueken MichaelLueken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panll I was able to clone your fork on Cheyenne and run the MET_verification test. I was able to see the new SPFH Z2 entries in the sfc file. I also saw several SPFH entries in the upa file. Out of curiosity, was there a reason why SPFH was added to upper_air, but not sfc?

I will go ahead and approve this this PR, though it might be an idea to change the title of this PR from Adding SPFH to Metplus config file to Adding SPFH to Metplus sfc config file.

@MichaelLueken MichaelLueken added the run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests label Jan 20, 2023
@panll
Copy link
Collaborator Author

panll commented Jan 20, 2023

@panll I was able to clone your fork on Cheyenne and run the MET_verification test. I was able to see the new SPFH Z2 entries in the sfc file. I also saw several SPFH entries in the upa file. Out of curiosity, was there a reason why SPFH was added to upper_air, but not sfc?

I will go ahead and approve this this PR, though it might be an idea to change the title of this PR from Adding SPFH to Metplus config file to Adding SPFH to Metplus sfc config file.

Thanks! @MichaelLueken SPFH is missed in sfc file (PointStat_conus_sfc.conf), so this pull request adds SPFH to the sfc file (PointStat_conus_sfc.conf) . In upper file (e.g., PointStat_upper_air.conf), SPFH has already existed. Thus no change is made to the upper file.

@JeffBeck-NOAA
Copy link
Collaborator

Hi @linlin-pan, thanks for adding specific humidity to the verification! I only see 2-m SPFH at the moment, though.

The upper air part is already included in file PointStat_upper_air.conf. Thanks @JeffBeck-NOAA !

Thank you, @linlin-pan! Approving now.

@panll panll merged commit 7ce093b into ufs-community:develop Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run_we2e_coverage_tests Run the coverage set of SRW end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants