-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UW-207 #121
Comments
Merged
11 tasks
Merged
11 tasks
WeirAE
added a commit
that referenced
this issue
Dec 6, 2022
…ing messages. (#121) (#122) * UW-207: As a user of the templater.py tool, I need to see useful logging messages.(#120) * Revert "UW-207: As a user of the templater.py tool," This reverts commit 38452cd. * UW-207: As a user of the templater.py tool, I need to see useful logging messages Corrected description and user from previous commit attempt * Fixed case error * Fixed comments and log handling in templater and updated test_templater to reflect verbosity
Reopening due to the commit reversion noted above. Problem has been replicated and identified, hopefully quick to correct. |
WeirAE
added a commit
that referenced
this issue
Dec 8, 2022
This was referenced Dec 9, 2022
UW-207 update: As a user of the templater.py tool, I need to see useful logging messages (#121)
#125
Merged
WeirAE
added a commit
that referenced
this issue
Dec 20, 2022
…ul logging messages (#121) (#125) * UW-207: As a user of the templater.py tool, I need to see useful logging messages.(#120) * Revert "UW-207: As a user of the templater.py tool," This reverts commit 38452cd. * UW-207: As a user of the templater.py tool, I need to see useful logging messages Corrected description and user from previous commit attempt * Fixed case error * Fixed comments and log handling in templater and updated test_templater to reflect verbosity * After previous issues in formatting, the following changes have been made: logger no longer writes timestamp to console this will be added back as an option in a later issue templater formatting now uses printf format for logs may need to be changed in a later issue if solved * Earlier code commented out has been removed * templater log name reverted and formatting changed to .format() version * Update templater.py Fixed "from uwtools.logger import Logger" and "return parser.parse_args(argv)" lost when attempting to resolve conflicts * Update templater.py And a bad indent, sheesh * Update test_templater.py Replaced ' verbose: False quiet: False' lost when attempting to resolve conflicts. * Several updates: logger.py default reverted templater now correctly defines streams tests for quiet and verbose logging added log format more fstring like where possible verbose log test needs some fixes still * Updated log parser to regex some match issues still to fix * Templater adds handler clear to verbose to fix duplicated streams test_templater now uses line in line logic for verbose test which is much more stable and clean * Rogue spaces removed * Last typo, I promise * Old remnant print() found and removed * Found yet another rogue print() * disabling consider-using-f-string for pylint * Empty push * Move disable=consider-using-f-string to templater * Cleaning up long messages * fussy line breaks * re-fixed * removed extraneous Logger load
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
https://jira-epic.woc.noaa.gov/browse/UW-207
The text was updated successfully, but these errors were encountered: