Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UW-207 #121

Closed
WeirAE opened this issue Nov 29, 2022 · 1 comment · Fixed by #122
Closed

UW-207 #121

WeirAE opened this issue Nov 29, 2022 · 1 comment · Fixed by #122
Assignees
Labels
feature Added functionality
Projects

Comments

@WeirAE
Copy link
Contributor

WeirAE commented Nov 29, 2022

https://jira-epic.woc.noaa.gov/browse/UW-207

@WeirAE WeirAE added the feature Added functionality label Nov 29, 2022
@WeirAE WeirAE self-assigned this Nov 29, 2022
@WeirAE WeirAE added this to To-Do in UW Tools via automation Nov 29, 2022
WeirAE added a commit that referenced this issue Dec 6, 2022
…ing messages. (#121) (#122)

* UW-207: As a user of the templater.py tool,
I need to see useful logging messages.(#120)

* Revert "UW-207: As a user of the templater.py tool,"

This reverts commit 38452cd.

* UW-207: As a user of the templater.py tool,
I need to see useful logging messages
Corrected description and user from previous commit attempt

* Fixed case error

* Fixed comments and log handling in templater and
updated test_templater to reflect verbosity
UW Tools automation moved this from To-Do to Done Dec 6, 2022
WeirAE added a commit that referenced this issue Dec 6, 2022
@WeirAE
Copy link
Contributor Author

WeirAE commented Dec 6, 2022

Reopening due to the commit reversion noted above. Problem has been replicated and identified, hopefully quick to correct.

@WeirAE WeirAE reopened this Dec 6, 2022
UW Tools automation moved this from Done to In progress Dec 6, 2022
WeirAE added a commit that referenced this issue Dec 8, 2022
…ful logging messages. (#121)" (#123)

Revert "UW-207: As a user of the templater.py tool, I need to see useful logging messages. (#121) (#122)"

This reverts commit 9dde12c.
WeirAE added a commit that referenced this issue Dec 20, 2022
…ul logging messages (#121) (#125)

* UW-207: As a user of the templater.py tool,
I need to see useful logging messages.(#120)

* Revert "UW-207: As a user of the templater.py tool,"

This reverts commit 38452cd.

* UW-207: As a user of the templater.py tool,
I need to see useful logging messages
Corrected description and user from previous commit attempt

* Fixed case error

* Fixed comments and log handling in templater and
updated test_templater to reflect verbosity

* After previous issues in formatting, the following
changes have been made:
logger no longer writes timestamp to console
this will be added back as an option in a later issue
templater formatting now uses printf format for logs
may need to be changed in a later issue if solved

* Earlier code commented out has been removed

* templater log name reverted and formatting
changed to .format() version

* Update templater.py

Fixed "from uwtools.logger import Logger" and "return parser.parse_args(argv)" lost when attempting to resolve conflicts

* Update templater.py

And a bad indent, sheesh

* Update test_templater.py

Replaced '        
      verbose: False
          quiet: False'
lost when attempting to resolve conflicts.

* Several updates: logger.py default reverted
templater now correctly defines streams
tests for quiet and verbose logging added
log format more fstring like where possible
verbose log test needs some fixes still

* Updated log parser to regex
some match issues still to fix

* Templater adds handler clear to verbose to fix
duplicated streams
test_templater now uses line in line logic for
verbose test which is much more stable and clean

* Rogue spaces removed

* Last typo, I promise

* Old remnant print() found and removed

* Found yet another rogue print()

* disabling consider-using-f-string for pylint

* Empty push

* Move disable=consider-using-f-string to templater

* Cleaning up long messages

* fussy line breaks

* re-fixed

* removed extraneous Logger load
@WeirAE WeirAE closed this as completed Dec 20, 2022
UW Tools automation moved this from In progress to Done Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Added functionality
Projects
No open projects
1 participant