-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Users Guide #180
Update Users Guide #180
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@j-derrico This looks great! Thank you!
I built the docs locally and looked around in the browser. I didn't see any failures, and I can't seem to see why the github check failed. Do you have any ideas.
If we can't spot that with fresh eyes later, maybe we just merge it and see if perhaps it is a permissions issue or something similar?
The content looks good.
Odd, it does build ok for me too, and technically it does say 'build successful' before it fails. I'll have to recheck with fresh eyes. There are several warnings on small formatting things but I'd be surprised if that was it. The first part reads a little ChatGPT-y, but its good! |
Is it possible to log in to readthedocs and see what happens when it builds from that side? |
@j-derrico Nice suggestion, I'm seeing that it also passed in the build history on RtDs as well. I'd say we go ahead with the merge, if you're okay with that this morning? I can push it through. |
I think the failure is likely related to this chunk of code in jobs/build_documentation.sh.
It seems like we aren't tolerating anything in the warnings file. EDIT: I see that my warnings file on my local build is not empty (workflow-tools/docs/_build/warnings.log) |
Ah, so it was the warnings - it looked like mostly indent and label complaints, I think thats fixable |
This content has been incorporating into getting_started.rst
@christinaholtNOAA and @j-derrico I was out of the office when you were originally discussing the warnings in this PR. I just wanted to follow up in case you didn't already know that in the GitHub Actions tab, you can find the Documentation run for the PR that failed and you can see there is an artifact at the bottom of that page called documentation_warnings.log that you can download and look at to see what the warnings are. I hope that is helpful information (which you can just ignore if you already knew). :) |
Fixes Issue ufs-community#177, Updating the UW Tools users guide
Fixes Issue ufs-community#177, Updating the UW Tools users guide
Description
Fixes Issue #177, Updating the UW Tools users guide
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Checklist