Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Users Guide #180

Merged
merged 19 commits into from
Mar 20, 2023
Merged

Update Users Guide #180

merged 19 commits into from
Mar 20, 2023

Conversation

j-derrico
Copy link
Contributor

Description
Fixes Issue #177, Updating the UW Tools users guide
Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes need updates to the documentation. I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j-derrico This looks great! Thank you!

I built the docs locally and looked around in the browser. I didn't see any failures, and I can't seem to see why the github check failed. Do you have any ideas.

If we can't spot that with fresh eyes later, maybe we just merge it and see if perhaps it is a permissions issue or something similar?

The content looks good.

@WeirAE
Copy link
Contributor

WeirAE commented Mar 18, 2023

Odd, it does build ok for me too, and technically it does say 'build successful' before it fails. I'll have to recheck with fresh eyes. There are several warnings on small formatting things but I'd be surprised if that was it. The first part reads a little ChatGPT-y, but its good!

@j-derrico
Copy link
Contributor Author

Is it possible to log in to readthedocs and see what happens when it builds from that side?

@christinaholtNOAA
Copy link
Contributor

@j-derrico Nice suggestion, I'm seeing that it also passed in the build history on RtDs as well. I'd say we go ahead with the merge, if you're okay with that this morning? I can push it through.

@christinaholtNOAA
Copy link
Contributor

christinaholtNOAA commented Mar 20, 2023

I think the failure is likely related to this chunk of code in jobs/build_documentation.sh.

warning_file=${DOCS_DIR}/_build/warnings.log
if [ -s $warning_file ]; then
  cp -r ${DOCS_DIR}/_build/warnings.log artifact/doc_warnings.log
  cp artifact/doc_warnings.log artifact/documentation
  exit 1
fi

It seems like we aren't tolerating anything in the warnings file.

EDIT: I see that my warnings file on my local build is not empty (workflow-tools/docs/_build/warnings.log)

@WeirAE
Copy link
Contributor

WeirAE commented Mar 20, 2023

Ah, so it was the warnings - it looked like mostly indent and label complaints, I think thats fixable

This content has been incorporating into getting_started.rst
@christinaholtNOAA christinaholtNOAA merged commit 8c89256 into develop Mar 20, 2023
@christinaholtNOAA christinaholtNOAA deleted the j-derrico-user-guide-1 branch March 20, 2023 15:59
@jprestop
Copy link
Contributor

@christinaholtNOAA and @j-derrico I was out of the office when you were originally discussing the warnings in this PR. I just wanted to follow up in case you didn't already know that in the GitHub Actions tab, you can find the Documentation run for the PR that failed and you can see there is an artifact at the bottom of that page called documentation_warnings.log that you can download and look at to see what the warnings are. I hope that is helpful information (which you can just ignore if you already knew). :)

WeirAE pushed a commit to WeirAE/workflow-tools that referenced this pull request Mar 29, 2023
Fixes Issue ufs-community#177, Updating the UW Tools users guide
WeirAE pushed a commit to WeirAE/workflow-tools that referenced this pull request Mar 29, 2023
Fixes Issue ufs-community#177, Updating the UW Tools users guide
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants