Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data format dropdown list free text option does not work as expected #466

Closed
mietcls opened this issue Aug 22, 2022 · 2 comments · Fixed by #592
Closed

Data format dropdown list free text option does not work as expected #466

mietcls opened this issue Aug 22, 2022 · 2 comments · Fixed by #592
Assignees
Labels
bug Something isn't working

Comments

@mietcls
Copy link
Member

mietcls commented Aug 22, 2022

Description bug

When trying to add non-predefined a data format:

  • the dropdown still tries to match one of the items in the list, if it found a similar match
  • the dropdown does not go away
  • it does not disappear after adding a new data format

Steps to reproduce

  1. Go to eliot https://eliot1.ugent.be/biblio-backend/dataset/
  2. Click "Edit" on the "Dataset details" inside "Description"
  3. Add values that match partially with suggested data formats (e.g. key or new)

It does not happen when you try to add a keyword that does not match at all:
Image

Example 1: Adding a data format "key"

One cannot enter "key"
Image

Example 2: Clicking the plus sign after adding "key"

Image

Example 3: Adding a data format "new" after adding "key"

Image

Example 4: Adding another random data format after adding the previous examples

Image

Example 5: matching one of the predefined "new" options

Image

Expected behaviour

  • You can add the "new" value entered
  • The dropdown goes away when you add a new keyword

Suggestion

Add "new" value to make action explicit at the bottom of the list

Image

Code example

<li class="list-group-item list-group-item-action d-flex justify-content-between align-items-center autocomplete-hit" data-value="application/pgp-keys"><strong>Add new data format "Key"</strong></li>

System information

Desktop

  • OS: macOS Monterey
  • Browser: Safari (Version 15.5), Chrome (latest), Firefox (latest)
@mietcls mietcls added the bug Something isn't working label Aug 22, 2022
@mietcls
Copy link
Member Author

mietcls commented Aug 23, 2022

You can not use free text, nor does the dropdown disappear when you try to do so:
Image

@mietcls mietcls changed the title When a data format doesnt have a match in the dropdown-list but still matches part of an item in the dropdown-list, the dropdown-list doesn't go away after clicking '+' to add a new data format Data format dropdown list free text option does not work as expected Sep 5, 2022
@mietcls mietcls added this to the 2022 Launch EOY milestone Sep 5, 2022
@mietcls
Copy link
Member Author

mietcls commented Sep 9, 2022

  • "Refresh staat niet goed"
  • Buiten het vak klikken werkt ook niet

@nicolasfranck nicolasfranck self-assigned this Sep 9, 2022
@nics nics closed this as completed in #592 Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants