Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fast-path of slice/map results in decode different from encode #37

Closed
armon opened this issue Oct 18, 2014 · 2 comments
Closed

Fast-path of slice/map results in decode different from encode #37

armon opened this issue Oct 18, 2014 · 2 comments

Comments

@armon
Copy link

armon commented Oct 18, 2014

The new changes to fast-path slices and maps has caused nil values to be replaced with non-nil zero values of the fields. This has caused lots of pain for us as the input is no longer equal to the output when serializing / deserializing. We've forked and rolled back to 71c2886

@ugorji
Copy link
Owner

ugorji commented Oct 18, 2014

Please send a short reproducer. It will make it easier to get a fix.

Thanks.
On Oct 17, 2014 9:42 PM, "Armon Dadgar" notifications@github.com wrote:

The new changes to fast-path slices and maps has caused nil values to be
replaced with non-nil zero values of the fields. This has caused lots of
pain for us as the input is no longer equal to the output when serializing
/ deserializing. We've forked and rolled back to 71c2886
71c2886


Reply to this email directly or view it on GitHub
#37.

@ugorji ugorji closed this as completed in b7f3bcb Oct 18, 2014
@ugorji
Copy link
Owner

ugorji commented Oct 18, 2014

The fast-paths afford a clear performance improvement. I advise that you stick to tip of the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants