Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v2.3.4) - Sinergym minor update #337

Merged
merged 6 commits into from
May 9, 2023
Merged

(v2.3.4) - Sinergym minor update #337

merged 6 commits into from
May 9, 2023

Conversation

AlejandroCN7
Copy link
Collaborator

Description

This PR include some minor changes in Sinergym tool and corrected one bug (see Changelog).

Motivation and Context

  • I have raised an issue to propose this change (required for new features and bug fixes)

Why is this change required? What problem does it solve? Please, reference issue or issues opened previously.

Fixes #334

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Improvement (of an existing feature)
  • Others

Checklist:

  • I've read the CONTRIBUTION guide (required)
  • My change requires a change to the documentation.
  • I have updated the tests.
  • I have updated the documentation accordingly.
  • I have reformatted the code using autopep8 second level aggressive.
  • I have reformatted the code using isort.
  • I have ensured cd docs && make spelling && make html pass (required if documentation has been updated.)
  • I have ensured pytest tests/ -vv pass. (required).
  • I have ensured pytype -d import-error sinergym/ pass. (required)

Changelog:

  • Replaced os kill episode for Popen.kill, solving permission error in some systems.
  • Updated RBC for 5zone summer setpoints. Now, default configuration for that RBC is appropriate with defaults environments.
  • Added Makefile extension in devcontainer.
  • Fixed Python locale bug with sphinx make in Dockerfile.
  • Update reward section and added equation in documentation.

@AlejandroCN7 AlejandroCN7 merged commit 83402f1 into main May 9, 2023
@AlejandroCN7 AlejandroCN7 deleted the bug/issue-334 branch May 9, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: PermissionError when call env.reset()
1 participant